You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/08/21 09:01:27 UTC
[GitHub] [netbeans] jtulach opened a new pull request, #4523: Improvements to incremental compilation of NetBeans
jtulach opened a new pull request, #4523:
URL: https://github.com/apache/netbeans/pull/4523
After few months I tried following on my repository
```
$ git pull
$ ant build
```
and run into bunch of compilation errors. These are the changes I had to make to let the incremental build pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1633021428
#5617 is already added my +1 on that PR, so sure ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1545728657
@jtulach - still relevant ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1633038498
> @matthiasblaesing @mbien can we just merge https://github.com/apache/netbeans/pull/5617 and remove the option from the UI!
fine I merge it :)
I just had the worry that this might encourage merges without *any* kind of squashing. Lets see if it improves the situation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jtulach commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by "jtulach (via GitHub)" <gi...@apache.org>.
jtulach commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1627622565
> I tried to see the problem myself and indeed it is reproducible with:
+1
> Anyway. For the concrete case the minimal fix is adding `<build-prerequisite />` is enough.
+1
> I'm not sure, though that it is a good idea to do this,
I see adding `<build-prerequisite>` as a proper fix. It says (in my opinion) _"make sure that module is **properly** compiled"_. Which it is not, if it is outdated.
> as next time the problem is a different module.
Probably. This kind of incremental issues is hard to spot and get completely right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1633016754
@matthiasblaesing @mbien can we just merge #5617 and remove the option from the UI!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1229197551
> I'm not sure, though that it is a good idea to do this, as next time the problem is a different module.
Let's do the minimal fix now, and talk/fix buildsystem as the next step (another PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1221598111
I tried to see the problem myself and indeed it is reproducible with:
```
git clean -f -x -d
git checkout 5573b9c9e8794ba43374347606509a5a4206a00a^
ant
git checkout 5573b9c9e8794ba43374347606509a5a4206a00a
ant
```
From my perspective this is not an issue in the module, but in the build-system. A module declares a versioned dependency and the build system (according to this test) the module to be present for this (although only the minimal runtime version is declared) and the build system does not ensure the module is build - this is broken.
Anyway. For the concrete case the minimal fix is adding `<build-prerequisite />` is enough.
I'm not sure, though that it is a good idea to do this, as next time the problem is a different module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jtulach merged pull request #4523: Improvements to incremental compilation of NetBeans
Posted by "jtulach (via GitHub)" <gi...@apache.org>.
jtulach merged PR #4523:
URL: https://github.com/apache/netbeans/pull/4523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jtulach commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by GitBox <gi...@apache.org>.
jtulach commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1221588529
> Can you describe the requirement for adding the `build-prerequisite` entries in the `c.jcraft.jsch` module?
> The module itself only repackages `jsch` as an OSGI module. According to the documentation `compile-dependency` implied
I got a failure that `c.jcraft.jsch` module cannot be compiled as it requires some other module in a version `x.y`, but only older `a.b` version was found. Requiring the build order fixes that problem. Maybe removing `<compile-dependency/>` would fix the problem as well, if there is no code to compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1382717579
conflicts would need to be resolved here to get this into NB17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4523: Improvements to incremental compilation of NetBeans
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #4523:
URL: https://github.com/apache/netbeans/pull/4523#issuecomment-1633008628
Please don't use the github "squash+merge" option if you user is not appropriately setup. The author of the resulting commit is:
Jaroslav Tulach <18...@users.noreply.github.com>
This is not correct. The author email is obviously invalid. We saw this multiple times now, the github UI is useless for squashing as it destroys information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists