You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/05/26 09:47:25 UTC
[GitHub] [lucene] romseygeek opened a new pull request #154: LUCENE-9454: Remove version field on Analyzer
romseygeek opened a new pull request #154:
URL: https://github.com/apache/lucene/pull/154
Version switching on Analyzer behaviour should be implemented
in the various component factories, rather than on a mutable
setting on Analyzer itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dsmiley commented on pull request #154: LUCENE-9454: Remove version field on Analyzer
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #154:
URL: https://github.com/apache/lucene/pull/154#issuecomment-848947225
@mikemccand I'm curious why you say:
> This was an overly complex approach to backwards compatibility!
I think it's rather simple, and the PR was simple as well showing it was a simple idea. If this approach is complex, what simple approach do you recommend instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek commented on pull request #154: LUCENE-9454: Remove version field on Analyzer
Posted by GitBox <gi...@apache.org>.
romseygeek commented on pull request #154:
URL: https://github.com/apache/lucene/pull/154#issuecomment-848901996
> +1, this is 9.0 only?
Yes, I should have made that clear, sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #154: LUCENE-9454: Remove version field on Analyzer
Posted by GitBox <gi...@apache.org>.
romseygeek merged pull request #154:
URL: https://github.com/apache/lucene/pull/154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org