[PR] Upgrade parent to maven-shared-components 49 [maven-reporting-api]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz opened a new pull request, #77:
URL: https://github.com/apache/maven-reporting-api/pull/77

   This branch's Jenkins build is currently failing:
   
   ```
   [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (rat-check)
           on project maven-reporting-api: Too many files with unapproved license: 1
   ```
   
   The cause is external to the repository. The ASF shared Jenkins library now provisions the Maven wrapper into the workspace before building (apache/maven-jenkins-lib#22), which writes `.mvn/wrapper/maven-wrapper.properties`. That file has no licence header, and the apache-rat **0.13** pinned by parent 34 counts it as unapproved.
   
   Verified locally, generating the wrapper exactly as CI does and running the check both ways:
   
   | parent | rat | result |
   |---|---|---|
   | 34 (current) | 0.13 | `Unapproved: 1, unknown: 1` — `rat.txt` names `.mvn/wrapper/maven-wrapper.properties` |
   | 49 (this PR) | 0.16.1 | `Unapproved: 0, unknown: 0, approved: 15` |
   
   `mvnw` and `mvnw.cmd` are fine either way — the wrapper ships those with ASF headers; only the `.properties` file lacks one.
   
   The source changes are spotless from the new parent, applied rather than hand-edited: the licence header moves above the `package` statement, imports are reordered, and the modern Maven brace/spacing style is applied. I removed the old post-package header blocks so the header is not duplicated — spotless adds the new one at the top but does not remove the old one. There are no code changes.
   
   `spotless:check` and `apache-rat:check` both pass locally. I could not run the full build here: the branch targets Java 7 and my local JDK is too new (`release version 7 not supported`); CI builds it on JDK 8/11/17.
   
   `maven-reporting-impl-3.x` is on parent 34 as well and will likely need the same treatment, though its build currently fails earlier on a missing `doxia-sink-api:1.12.0-SNAPSHOT`. Context in apache/maven#12676.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade parent to maven-shared-components 49 [maven-reporting-api]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz merged PR #77:
URL: https://github.com/apache/maven-reporting-api/pull/77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade parent to maven-shared-components 49 [maven-reporting-api]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #77:
URL: https://github.com/apache/maven-reporting-api/pull/77#issuecomment-5183579717

   @slachiewicz The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: maven-reporting-api-3.x" to the description to the milestone where this PR belongs to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org