You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Mirko Friedenhagen <mf...@apache.org> on 2017/01/01 15:37:20 UTC

GitHub pull requests without JIRA issue

Hello PMCs et al,

I commented on a PR on GitHub a while ago with a change to documentation of
the Maven site plugin. This slipped through my fingers and now the reporter
asked how to submit patches to the Apache Maven project.

I guess this is documented here (
https://maven.apache.org/guides/development/guide-helping.html), where it
says you have to create an issue in the issue tracker.

Is creating a JIRA issue necessary for small changes as well?

Or is a pull request sufficient?

Is there a difference between projects still in SVN  (no real git merge) vs
GIT (real merge of a branch)

Sorry if this has been discussed before, at least I did not find the
discussion.


Regards
Mirko
-- 
Sent from my mobile

Re: GitHub pull requests without JIRA issue

Posted by Hervé BOUTEMY <he...@free.fr>.
on "since these pages are managed via cms.apache.org/"
these pages are managed through svn, ie either edited locally or through CMS.
CMS is necessary only to build and publish the generated content

then for site, a PR is sufficient in general: will be integrated manually to svn

Regards,

Hervé

Le dimanche 1 janvier 2017, 17:21:30 CET Robert Scholte a écrit :
> Hi Mirko,
> 
> The JIRA for these pages is MNGSITE, but is often not required (tracking
> such changes don't really have value)
> A PR is hard, since these pages are managed via cms.apache.org/
> These changes have a small workflow and and can be published within
> minutes.
> 
> Robert
> 
> On Sun, 01 Jan 2017 16:37:20 +0100, Mirko Friedenhagen
> 
> <mf...@apache.org> wrote:
> > Hello PMCs et al,
> > 
> > I commented on a PR on GitHub a while ago with a change to documentation
> > of
> > the Maven site plugin. This slipped through my fingers and now the
> > reporter
> > asked how to submit patches to the Apache Maven project.
> > 
> > I guess this is documented here (
> > https://maven.apache.org/guides/development/guide-helping.html), where it
> > says you have to create an issue in the issue tracker.
> > 
> > Is creating a JIRA issue necessary for small changes as well?
> > 
> > Or is a pull request sufficient?
> > 
> > Is there a difference between projects still in SVN  (no real git merge)
> > vs
> > GIT (real merge of a branch)
> > 
> > Sorry if this has been discussed before, at least I did not find the
> > discussion.
> > 
> > 
> > Regards
> > Mirko
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: GitHub pull requests without JIRA issue

Posted by Robert Scholte <rf...@apache.org>.
Hi Mirko,

The JIRA for these pages is MNGSITE, but is often not required (tracking  
such changes don't really have value)
A PR is hard, since these pages are managed via cms.apache.org/
These changes have a small workflow and and can be published within  
minutes.

Robert

On Sun, 01 Jan 2017 16:37:20 +0100, Mirko Friedenhagen  
<mf...@apache.org> wrote:

> Hello PMCs et al,
>
> I commented on a PR on GitHub a while ago with a change to documentation  
> of
> the Maven site plugin. This slipped through my fingers and now the  
> reporter
> asked how to submit patches to the Apache Maven project.
>
> I guess this is documented here (
> https://maven.apache.org/guides/development/guide-helping.html), where it
> says you have to create an issue in the issue tracker.
>
> Is creating a JIRA issue necessary for small changes as well?
>
> Or is a pull request sufficient?
>
> Is there a difference between projects still in SVN  (no real git merge)  
> vs
> GIT (real merge of a branch)
>
> Sorry if this has been discussed before, at least I did not find the
> discussion.
>
>
> Regards
> Mirko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org