You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/10 23:13:05 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #20796: Better signing instructions for helm chart releases
jedcunningham opened a new pull request #20796:
URL: https://github.com/apache/airflow/pull/20796
The primary change here is using the [helm gpg](https://github.com/technosophos/helm-gpg) plugin to sign the chart instead of using the default sign/verify in helm. This allows more modern GPG features to be used, e.g. a smartcard, instead of relying on a GnuPG v1 binary keyring containing the private key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #20796: Better signing instructions for helm chart releases
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #20796:
URL: https://github.com/apache/airflow/pull/20796#discussion_r782498283
##########
File path: dev/README_RELEASE_HELM_CHART.md
##########
@@ -122,65 +122,66 @@ official Apache releases must not include the rcN suffix.
```
- Update Helm Chart version in `Chart.yaml`, example: `version: 1.0.0` (without
- the RC tag). If the default version of Airflow is different from `appVersion` change it.
+ the RC tag).
Review comment:
It's part of the Airflow release process, and should also be caught in reviews when it gets bumped:
https://github.com/apache/airflow/blob/0afe3d129db2792f58f6fd8cc5e278aba9cf166c/dev/README_RELEASE_AIRFLOW.md?plain=1#L966-L968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20796: Better signing instructions for helm chart releases
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20796:
URL: https://github.com/apache/airflow/pull/20796#discussion_r782496651
##########
File path: dev/README_RELEASE_HELM_CHART.md
##########
@@ -122,65 +122,66 @@ official Apache releases must not include the rcN suffix.
```
- Update Helm Chart version in `Chart.yaml`, example: `version: 1.0.0` (without
- the RC tag). If the default version of Airflow is different from `appVersion` change it.
+ the RC tag).
Review comment:
Do we not need to take care of it anymore - "If the default version of Airflow is different from `appVersion` change it."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #20796: Better signing instructions for helm chart releases
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #20796:
URL: https://github.com/apache/airflow/pull/20796#discussion_r782498514
##########
File path: dev/README_RELEASE_HELM_CHART.md
##########
@@ -122,65 +122,66 @@ official Apache releases must not include the rcN suffix.
```
- Update Helm Chart version in `Chart.yaml`, example: `version: 1.0.0` (without
- the RC tag). If the default version of Airflow is different from `appVersion` change it.
+ the RC tag).
Review comment:
We can leave this in though, I don't have a strong preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20796: Better signing instructions for helm chart releases
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20796:
URL: https://github.com/apache/airflow/pull/20796#discussion_r782499563
##########
File path: dev/README_RELEASE_HELM_CHART.md
##########
@@ -122,65 +122,66 @@ official Apache releases must not include the rcN suffix.
```
- Update Helm Chart version in `Chart.yaml`, example: `version: 1.0.0` (without
- the RC tag). If the default version of Airflow is different from `appVersion` change it.
+ the RC tag).
Review comment:
I will vote for keeping it in case this was missed when releasing Airflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20796: Better signing instructions for helm chart releases
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20796:
URL: https://github.com/apache/airflow/pull/20796#issuecomment-1010333090
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #20796: Better signing instructions for helm chart releases
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20796:
URL: https://github.com/apache/airflow/pull/20796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #20796: Better signing instructions for helm chart releases
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #20796:
URL: https://github.com/apache/airflow/pull/20796#discussion_r782508919
##########
File path: dev/README_RELEASE_HELM_CHART.md
##########
@@ -122,65 +122,66 @@ official Apache releases must not include the rcN suffix.
```
- Update Helm Chart version in `Chart.yaml`, example: `version: 1.0.0` (without
- the RC tag). If the default version of Airflow is different from `appVersion` change it.
+ the RC tag).
Review comment:
```suggestion
the RC tag). If the default version of Airflow is different from `appVersion` change it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org