You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "MonsterChenzhuo (via GitHub)" <gi...@apache.org> on 2023/03/21 17:10:17 UTC
[GitHub] [incubator-seatunnel] MonsterChenzhuo opened a new pull request, #4389: [WIP][Feature][Connector-v2][Mongodb]Refactor mongodb source connector
MonsterChenzhuo opened a new pull request, #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FlechazoW commented on a diff in pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "FlechazoW (via GitHub)" <gi...@apache.org>.
FlechazoW commented on code in PR #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389#discussion_r1165083551
##########
seatunnel-connectors-v2/connector-mongodb-v2/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodbv2/sink/config/MongoWriteOptions.java:
##########
@@ -0,0 +1,180 @@
+/// *
Review Comment:
Why comment out the entire file instead of deleting it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on code in PR #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389#discussion_r1167975623
##########
seatunnel-examples/seatunnel-flink-connector-v2-example/src/main/resources/examples/fake_to_console.conf:
##########
@@ -18,14 +18,6 @@
###### This config file is a demonstration of streaming processing in seatunnel config
######
-env {
Review Comment:
Why change it?
##########
seatunnel-examples/seatunnel-engine-examples/pom.xml:
##########
@@ -62,5 +62,10 @@
<artifactId>connector-console</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Why change it?
##########
seatunnel-dist/pom.xml:
##########
@@ -353,6 +353,12 @@
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>connector-mongodb-v2</artifactId>
Review Comment:
No v2, delete old codes.
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-mongodb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/v2/mongodb/MongodbIT.java:
##########
@@ -53,18 +44,23 @@
import java.io.IOException;
import java.math.BigDecimal;
+import java.nio.charset.StandardCharsets;
import java.time.Duration;
-import java.time.LocalDate;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.Arrays;
+import java.util.Date;
import java.util.List;
+import java.util.Random;
import java.util.concurrent.TimeUnit;
import java.util.stream.Stream;
import static java.net.HttpURLConnection.HTTP_OK;
import static java.net.HttpURLConnection.HTTP_UNAUTHORIZED;
@Slf4j
+@DisabledOnContainer(
+ value = {},
+ type = {EngineType.FLINK, EngineType.SPARK})
Review Comment:
Why disabled flink and spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] MonsterChenzhuo commented on pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "MonsterChenzhuo (via GitHub)" <gi...@apache.org>.
MonsterChenzhuo commented on PR #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389#issuecomment-1514258715
cc @hailin0 @FlechazoW @TyrantLucifer Thanks for your review,I have made the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] MonsterChenzhuo commented on pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "MonsterChenzhuo (via GitHub)" <gi...@apache.org>.
MonsterChenzhuo commented on PR #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389#issuecomment-1493035907
cc @hailin0 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] MonsterChenzhuo commented on pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "MonsterChenzhuo (via GitHub)" <gi...@apache.org>.
MonsterChenzhuo commented on PR #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389#issuecomment-1510795397
cc @hailin0 @TyrantLucifer @FlechazoW Thanks for your review,I have made the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4389: [WIP][Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389#issuecomment-1484712980
check ci error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] FlechazoW commented on a diff in pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "FlechazoW (via GitHub)" <gi...@apache.org>.
FlechazoW commented on code in PR #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389#discussion_r1165080525
##########
seatunnel-examples/seatunnel-flink-connector-v2-example/pom.xml:
##########
@@ -62,6 +62,11 @@
<artifactId>connector-fake</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>connector-mongodb-v2</artifactId>
+ <version>2.3.1-SNAPSHOT</version>
Review Comment:
Do use '2.3.1-SNAPSHOT', use ${revison} or ${project.version} instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4389:
URL: https://github.com/apache/incubator-seatunnel/pull/4389#issuecomment-1514264852
Why not trigger e2e？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] MonsterChenzhuo closed pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
Posted by "MonsterChenzhuo (via GitHub)" <gi...@apache.org>.
MonsterChenzhuo closed pull request #4389: [Feature][Connector-v2][Mongodb]Refactor mongodb source connector
URL: https://github.com/apache/incubator-seatunnel/pull/4389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org