[GitHub] qpid-dispatch pull request #84: DISPATCH-401 - Made qdstat and qdmanage veri...

[ted-ross <gi...@git.apache.org>]

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/84#discussion_r70125810
  
    --- Diff: python/qpid_dispatch_internal/tools/command.py ---
    @@ -83,6 +83,9 @@ def connection_options(options, title="Connection Options"):
                          help="Trusted Certificate Authority Database file (PEM Format)")
         group.add_option("--ssl-password", action="store", type="string", metavar="PASSWORD",
                          help="Certificate password, will be prompted if not specifed.")
    +    group.add_option("--ssl-allow-peer-name-mismatch", action="store_true", default=False,
    +                     help="Verify the peer host name matches the certificate. Default true, "
    +                          "setting to false is insecure .")
         return group
    --- End diff --
    
    The name of this option seems inverted.  Allowing a mismatch is insecure, no?  How about "--ssl-verify-hostname"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org