You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org> on 2008/04/29 12:25:56 UTC
[jira] Created: (TUSCANY-2277) Standardization of registering msg
with monitor
Standardization of registering msg with monitor
-----------------------------------------------
Key: TUSCANY-2277
URL: https://issues.apache.org/jira/browse/TUSCANY-2277
Project: Tuscany
Issue Type: Bug
Components: Java SCA Assembly Model
Affects Versions: Java-SCA-Next
Environment: Windows XP
Reporter: Ramkumar Ramalingam
Assignee: Ramkumar Ramalingam
Fix For: Java-SCA-Next
Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
Here are some examples for the inconsistency.......
BaseConfigurationBuilderImpl.java
Here we raise only a warning for URISyntaxException, should we not throw an exception too?
BaseWireBuilderImpl.java
Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
CompositeProcessor.java
There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
>From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Simon Laws (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597473#action_12597473 ]
Simon Laws commented on TUSCANY-2277:
-------------------------------------
Hi Ram
Was just trying to apply these patches and am having a few problems. What tool did you use to generate them? I'm guessing Msftedit from the header. Can you regenerate them using a diff tool. Let me know if you need some help.
The issues I'm having are....
- has a strange Msft header (I can libe with this as I can remove it nmanually)
- the file dirs are absolute (I can live with this as I can go in and edit)
- there are some escaped charaters in there, e.g. \tab, \par, \{, \} which mess it up. (I can't get round this as fixing manually messes up the formatting and the patch tool can't then match the patch against the original code)
Thanks
Simon
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part1-New.rtf
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597544#action_12597544 ]
Ramkumar Ramalingam commented on TUSCANY-2277:
----------------------------------------------
Hi Simon,
The issue seems to be due to subeclipse. I did not realize that such characters would crop up due to subeclipse. I apologies for the inconvenience. I am just uploading a new set of patch for the same fixes.
Thanks,
Ramkumar R
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part3-New.patch
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1-New.patch, TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2-New.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3-New.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part1-New.patch
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1-New.patch, TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2-New.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3-New.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part1.patch
As the changes seems to be huge for this issue, i am providing with a incremental patch... more patches are in the pipe-line. Here I have attached Part1 of the changes.
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Ramkumar Ramalingam
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part2-New.patch
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1-New.patch, TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2-New.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3-New.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part1.patch
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Ramkumar Ramalingam
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Simon Laws (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Laws reassigned TUSCANY-2277:
-----------------------------------
Assignee: Simon Laws (was: Ramkumar Ramalingam)
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: (was: TUSCANY-2277-Part1-New.rtf)
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: (was: TUSCANY-2277-Part1-New.patch)
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Simon Laws (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Laws resolved TUSCANY-2277.
---------------------------------
Resolution: Fixed
Checked in at r657881. Thanks Ram
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1-New.patch, TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2-New.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3-New.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: (was: TUSCANY-2277-Part1.patch)
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Ramkumar Ramalingam
> Fix For: Java-SCA-Next
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part3.patch
TUSCANY-2277-Part2.patch
TUSCANY-2277-Part1.patch
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Ramkumar Ramalingam
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: (was: TUSCANY-2277-Part1.patch)
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Ramkumar Ramalingam
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2277) Standardization of registering msg
with monitor
Posted by "Ramkumar Ramalingam (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Ramalingam updated TUSCANY-2277:
-----------------------------------------
Attachment: TUSCANY-2277-Part1-New.patch
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1-New.patch, TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch, TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the code, found that we have some inconsistency interms of raising warning & errors. In some places we throw exceptions and in other places we raise a warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe registering this msg with a monitor is also required as this is caused by incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we will fix the issue as discussed....
> http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.