You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/02 23:52:36 UTC

[GitHub] [spark] gengliangwang opened a new pull request #24518: [SPARK-27627][SQL] Make option "pathGlobFilter" as a general option for all file sources

gengliangwang opened a new pull request #24518: [SPARK-27627][SQL] Make option "pathGlobFilter" as a general option for all file sources
URL: https://github.com/apache/spark/pull/24518
 
 
   ## What changes were proposed in this pull request?
   
   ### Background:
   The data source option `pathGlobFilter` is introduced for Binary file format: https://github.com/apache/spark/pull/24354 , which can be used for filtering file names, e.g. reading `.png` files only while there is `.json` files in the same directory.
   
   ### Proposal:
   Make the option `pathGlobFilter` as a general option for all file sources. The path filtering should happen in the path globbing on Driver.
   
   ### Motivation:
   Filtering the file path names in file scan tasks on executors is kind of ugly.
   
   ### Impact:
   1. The splitting of file partitions will be more balanced.
   2. The metrics of file scan will be more accurate.
   3. Users can use the option for reading other file sources.
   
   ## How was this patch tested?
   
   Unit tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org