You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by iyovcheva <gi...@git.apache.org> on 2015/08/18 18:57:52 UTC
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming brooklyn....
GitHub user iyovcheva opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/842
[BROOKLYN-162] Renaming brooklyn.entity.rebind.persister.jclouds in .…
…/locations/jclouds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyovcheva/incubator-brooklyn renaming-locations-jclouds-entity
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #842
----
commit 3d4cb36c7600f2cc15a6ce56c200aedd26ee4f23
Author: Ivana Yovcheva <iv...@gmail.com>
Date: 2015-08-18T16:33:51Z
[BROOKLYN-162] Renaming brooklyn.entity.rebind.persister.jclouds in ./locations/jclouds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming brooklyn....
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/842#issuecomment-132322990
Actually, @ahgittin has commented on IRC that he will try to "finish the rest" tonight.
I expect he'll rename these packages to a prefix like `org.apache.brooklyn.location.jclouds.*`, so me merging this could cause him merge conflicts.
I'll leave @ahgittin to decide whether to merge this, or whether his work is going to supersede this tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming brooklyn....
Posted by iyovcheva <gi...@git.apache.org>.
Github user iyovcheva closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/842
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming brooklyn....
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/842#issuecomment-132480359
hi @iyovcheva can you close? this conflicts w #844 which does a slightly different rename (inter alia). any comments you have there are welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming brooklyn....
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/842#issuecomment-132321952
Thanks @iyovcheva - I think we should move to renaming things in bigger chunks than this. Our package renaming is taking a long time, and multiple change PRs are ending up causing merge conflicts for each other. I think we're going to have a blast at lots of renaming tonight.
I'll merge this first though (after I check that it builds locally for me).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---