[GitHub] [helix] narendly commented on a change in pull request #863: Make ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #863: Make ZkCacheBaseDataAccessor and ZkHelixPropertyStore realm-aware
URL: https://github.com/apache/helix/pull/863#discussion_r389791303
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
 ##########
 @@ -842,4 +894,116 @@ public void close() {
       _zkClient.close();
     }
   }
+
+  public static class Builder {
 
 Review comment:
   @lei-xia 
   1. See https://github.com/apache/helix/issues/873 . We will do this once all Helix Java APIs have been implemented since this is a purely *internal* implementation detail. User-facing APIs stay the same.
   
   2. No, please see existing constructors for the fallback logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org