You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Aleksander Ściborek <al...@gmail.com> on 2019/01/29 00:04:35 UTC
[LANG] Checked Functions PR
I've just created pull request
<https://github.com/apache/commons-lang/pull/401> to a set of functions
which are wrappers for standard interfaces from java.util.function.
The idea behind this is that you can create an instance of a function which
throws a checked exception and then using a static method create an
instance of standard function which invocation of a checked functions.
Those interfaces were designed in order to using stream API easier
Re: [LANG] Checked Functions PR
Posted by Aleksander Ściborek <al...@gmail.com>.
Yes i saw
https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob_plain;f=src/main/java/org/apache/commons/lang3/Functions.java;h=5eaed0c6fa8dbb8ed7a2ba37d499130ba62f138b;hb=HEAD,
unfortunately it was created after I had developed my interfaces. I saw
there are some difference, like no methods to transform to a failable
function to a plain java function, and I'm going to add some high order
functions. Hover if community decide that my work is redundant i'll close
this pull request.
On Wed, 30 Jan 2019 at 20:58, Pascal Schumacher <pa...@gmx.net>
wrote:
> Am 30.01.2019 um 20:27 schrieb Jochen Wiedmann:
> > Have you seen [1]?
> >
> > 1:
> https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob_plain;f=src/main/java/org/apache/commons/lang3/Functions.java;h=5eaed0c6fa8dbb8ed7a2ba37d499130ba62f138b;hb=HEAD
>
> By the way:
>
>
> https://github.com/apache/commons-lang/commit/11d9eb47a40359e74a5e24daf681beacd71b35f0
>
>
> https://github.com/apache/commons-lang/commit/2ebc17ba3f244ae44aae46273aeef7e321f9542a
>
> break the (travis-ci) build, because:
>
> - FunctionsTest is missing the apache license header
>
> - Functions and FunctionsTest contain check-style violations
>
> Please run `mvn` and fix the issues reported.
>
> Thanks,
>
> Pascal
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [LANG] Checked Functions PR
Posted by Pascal Schumacher <pa...@gmx.net>.
Am 30.01.2019 um 20:27 schrieb Jochen Wiedmann:
> Have you seen [1]?
>
> 1: https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob_plain;f=src/main/java/org/apache/commons/lang3/Functions.java;h=5eaed0c6fa8dbb8ed7a2ba37d499130ba62f138b;hb=HEAD
By the way:
https://github.com/apache/commons-lang/commit/11d9eb47a40359e74a5e24daf681beacd71b35f0
https://github.com/apache/commons-lang/commit/2ebc17ba3f244ae44aae46273aeef7e321f9542a
break the (travis-ci) build, because:
- FunctionsTest is missing the apache license header
- Functions and FunctionsTest contain check-style violations
Please run `mvn` and fix the issues reported.
Thanks,
Pascal
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [LANG] Checked Functions PR
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Tue, Jan 29, 2019 at 1:04 AM Aleksander Ściborek
<al...@gmail.com> wrote:
> The idea behind this is that you can create an instance of a function which
> throws a checked exception and then using a static method create an
> instance of standard function which invocation of a checked functions.
Have you seen [1]?
1: https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob_plain;f=src/main/java/org/apache/commons/lang3/Functions.java;h=5eaed0c6fa8dbb8ed7a2ba37d499130ba62f138b;hb=HEAD
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [LANG] Checked Functions PR
Posted by Aleksander Ściborek <al...@gmail.com>.
I'm going to add those functionalities (default methods).
On Tue, 29 Jan 2019 at 16:56, Matt Sicker <bo...@gmail.com> wrote:
> I like this idea in theory. What would really make this shine is
> including similar default methods as the unchecked classes.
> Matt Sicker <bo...@gmail.com>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [LANG] Checked Functions PR
Posted by Matt Sicker <bo...@gmail.com>.
I like this idea in theory. What would really make this shine is
including similar default methods as the unchecked classes.
On Mon, 28 Jan 2019 at 18:04, Aleksander Ściborek
<al...@gmail.com> wrote:
>
> I've just created pull request
> <https://github.com/apache/commons-lang/pull/401> to a set of functions
> which are wrappers for standard interfaces from java.util.function.
> The idea behind this is that you can create an instance of a function which
> throws a checked exception and then using a static method create an
> instance of standard function which invocation of a checked functions.
> Those interfaces were designed in order to using stream API easier
--
Matt Sicker <bo...@gmail.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org