You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/12/20 22:07:17 UTC
Review Request 64758: Added a test to ensure MOUNT disk resource is
allocated exclusively.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64758/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Michael Park.
Repository: mesos
Description
-------
While quota allocation should be fine-grained, some resources are
exclusive. They cannot be chopped into finer granularity and have
to be offered entirely. This test verifies one of the cases: disk
resource of type MOUNT.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 173e4fbac184ad8d40c8adba19ad64225f11f1f2
Diff: https://reviews.apache.org/r/64758/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 64758: Added a test to ensure MOUNT disk resource
is allocated exclusively.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64758/#review194276
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 64003.
Failed command: `python.exe .\support\apply-reviews.py -n -r 64003`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64758
Relevant logs:
- [apply-review-64003-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64758/logs/apply-review-64003-stderr.log):
```
Traceback (most recent call last):
File ".\support\apply-reviews.py", line 434, in <module>
main()
File ".\support\apply-reviews.py", line 429, in main
reviewboard(options)
File ".\support\apply-reviews.py", line 419, in reviewboard
apply_review(options)
File ".\support\apply-reviews.py", line 160, in apply_review
commit_patch(options)
File ".\support\apply-reviews.py", line 271, in commit_patch
message.write(data['message'])
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 112: ordinal not in range(128)
```
- Mesos Reviewbot Windows
On Dec. 20, 2017, 2:07 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64758/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 2:07 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While quota allocation should be fine-grained, some resources are
> exclusive. They cannot be chopped into finer granularity and have
> to be offered entirely. This test verifies one of the cases: disk
> resource of type MOUNT.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 173e4fbac184ad8d40c8adba19ad64225f11f1f2
>
>
> Diff: https://reviews.apache.org/r/64758/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64758: Added a test to ensure MOUNT disk resource
is allocated exclusively.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64758/#review194288
-----------------------------------------------------------
Looks good!
Rather than "exclusively" how about all-or-nothing or is not chopped during allocation? Exclusively seems to suggest on its own without anything else.
src/tests/hierarchical_allocator_tests.cpp
Lines 3390 (patched)
<https://reviews.apache.org/r/64758/#comment273033>
Maybe indivisible or unchoppable instead of exclusive?
src/tests/hierarchical_allocator_tests.cpp
Lines 3393 (patched)
<https://reviews.apache.org/r/64758/#comment273034>
Ditto here.
src/tests/hierarchical_allocator_tests.cpp
Lines 3403 (patched)
<https://reviews.apache.org/r/64758/#comment273035>
seems like agentResources should include the mount disk?
src/tests/hierarchical_allocator_tests.cpp
Lines 3476-3478 (patched)
<https://reviews.apache.org/r/64758/#comment273036>
This subtraction a little puzzling to follow, is it possible to just use agent3.resources() - some disk due to chopping?
- Benjamin Mahler
On Dec. 20, 2017, 10:07 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64758/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 10:07 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While quota allocation should be fine-grained, some resources are
> exclusive. They cannot be chopped into finer granularity and have
> to be offered entirely. This test verifies one of the cases: disk
> resource of type MOUNT.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 173e4fbac184ad8d40c8adba19ad64225f11f1f2
>
>
> Diff: https://reviews.apache.org/r/64758/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64758: Added a test to ensure MOUNT disk is not
chopped during allocation.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64758/#review194302
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Dec. 21, 2017, 2:48 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64758/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2017, 2:48 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While quota allocation should be fine-grained, some resources are
> unchoppable. They have to be offered entirely. This test verifies
> one of the cases: disk resource of type MOUNT.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 173e4fbac184ad8d40c8adba19ad64225f11f1f2
>
>
> Diff: https://reviews.apache.org/r/64758/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64758: Added a test to ensure MOUNT disk is not
chopped during allocation.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64758/
-----------------------------------------------------------
(Updated Dec. 20, 2017, 6:48 p.m.)
Review request for mesos, Benjamin Mahler and Michael Park.
Summary (updated)
-----------------
Added a test to ensure MOUNT disk is not chopped during allocation.
Repository: mesos
Description (updated)
-------
While quota allocation should be fine-grained, some resources are
unchoppable. They have to be offered entirely. This test verifies
one of the cases: disk resource of type MOUNT.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 173e4fbac184ad8d40c8adba19ad64225f11f1f2
Diff: https://reviews.apache.org/r/64758/diff/2/
Changes: https://reviews.apache.org/r/64758/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu