You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2018/08/08 15:33:08 UTC

[4/5] activemq-artemis git commit: NO-JIRA fix flaky tests QueueControlTest#testChangeMessagePriority{, WithInvalidValue}

NO-JIRA fix flaky tests QueueControlTest#testChangeMessagePriority{,WithInvalidValue}

The occasional assertion error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.

(cherry picked from commit c6521e0700006de1a00b614768168a0f96c5e28b)


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/f2852cb9
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/f2852cb9
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/f2852cb9

Branch: refs/heads/2.6.x
Commit: f2852cb9dcdf7617a65bf763a59d28e43d1eff9a
Parents: b08bff0
Author: Jiri Danek <jd...@redhat.com>
Authored: Tue Aug 7 20:02:41 2018 +0200
Committer: Clebert Suconic <cl...@apache.org>
Committed: Wed Aug 8 11:32:45 2018 -0400

----------------------------------------------------------------------
 .../artemis/tests/integration/management/QueueControlTest.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/f2852cb9/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
index 46d360e..9f4a93c 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
@@ -1926,7 +1926,7 @@ public class QueueControlTest extends ManagementTestBase {
       producer.send(message);
 
       QueueControl queueControl = createManagementControl(address, queue);
-      Assert.assertEquals(1, getMessageCount(queueControl));
+      Wait.assertEquals(1, () -> getMessageCount(queueControl));
 
       // the message IDs are set on the server
       Map<String, Object>[] messages = queueControl.listMessages(null);
@@ -1959,7 +1959,7 @@ public class QueueControlTest extends ManagementTestBase {
       producer.send(message);
 
       QueueControl queueControl = createManagementControl(address, queue);
-      Assert.assertEquals(1, getMessageCount(queueControl));
+      Wait.assertEquals(1, () -> getMessageCount(queueControl));
 
       // the message IDs are set on the server
       Map<String, Object>[] messages = queueControl.listMessages(null);