[GitHub] [flink] qingwei91 commented on a diff in pull request #20119: [FLINK-28322][table-api] DataStreamScan(Sink)Provider's new method is not compatible

[GitBox <gi...@apache.org>]

qingwei91 commented on code in PR #20119:
URL: https://github.com/apache/flink/pull/20119#discussion_r912527749


##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/sink/DataStreamSinkProvider.java:
##########
@@ -54,8 +54,10 @@
      *
      * @see SingleOutputStreamOperator#uid(String)
      */
-    DataStreamSink<?> consumeDataStream(
-            ProviderContext providerContext, DataStream<RowData> dataStream);
+    default DataStreamSink<?> consumeDataStream(
+            ProviderContext providerContext, DataStream<RowData> dataStream) {
+        return consumeDataStream(dataStream);

Review Comment:
   Hi, can you elaborate what is the consequence of using this default implementation? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org