You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/23 13:31:23 UTC

[GitHub] sakshi2894 opened a new pull request #3790: [AIRFLOW-2994] Fix command status check in Qubole Check operator

sakshi2894 opened a new pull request #3790: [AIRFLOW-2994] Fix command status check in Qubole Check operator
URL: https://github.com/apache/incubator-airflow/pull/3790
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-2994\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2994
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   Exception message shouldn't contain Qubole command results if the command fails. This PR fixes a bug which causes this behaviour.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests:
   `test_execute_assert_query_fail` - Tests that the exception message doesn't contain Qubole command id and results if the command has failed.
   
   
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services