You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/22 09:58:12 UTC
[GitHub] [maven-archiver] jorsol opened a new pull request, #21: Require Maven 3.2.5+
jorsol opened a new pull request, #21:
URL: https://github.com/apache/maven-archiver/pull/21
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] slawekjaranowski commented on pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #21:
URL: https://github.com/apache/maven-archiver/pull/21#issuecomment-1106374062
@jorsol please investigate what happened with site build
```
mvn -P reporting site
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] jorsol commented on pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
jorsol commented on PR #21:
URL: https://github.com/apache/maven-archiver/pull/21#issuecomment-1107417363
Weird, it works for me with the same command (tested on JDK 8, 11, 17, 19-ea):
```
09:43:47.464 [INFO] Generating "Test Javadoc" report --- maven-javadoc-plugin:3.3.2:test-javadoc
09:43:47.547 [INFO] Configuration changed, re-generating javadoc.
09:43:48.924 [WARNING] Javadoc Warnings
09:43:48.924 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/ManifestConfigurationTest.java:27: warning: no comment
09:43:48.924 [WARNING] public class ManifestConfigurationTest
09:43:48.924 [WARNING] ^
09:43:48.924 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/ManifestConfigurationTest.java:33: warning: no comment
09:43:48.924 [WARNING] public void before()
09:43:48.924 [WARNING] ^
09:43:48.924 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/ManifestConfigurationTest.java:45: warning: no comment
09:43:48.924 [WARNING] public void getClasspathPrefixShouldReturnPrefixWithSlashesInsteadOfBackSlashes()
09:43:48.924 [WARNING] ^
09:43:48.924 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/ManifestConfigurationTest.java:52: warning: no comment
09:43:48.924 [WARNING] public void getClasspathPrefixShouldReturnPrefixWithTraingSlash()
09:43:48.924 [WARNING] ^
09:43:48.924 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/ManifestConfigurationTest.java:59: warning: no comment
09:43:48.924 [WARNING] public void getClasspathPrefixShouldReturnTheTrailingSlash()
09:43:48.924 [WARNING] ^
09:43:48.924 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/ManifestConfigurationTest.java:39: warning: no comment
09:43:48.924 [WARNING] public void XXX()
09:43:48.924 [WARNING] ^
09:43:48.924 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiveConfigurationTest.java:49: warning: no comment
09:43:48.924 [WARNING] public void addingSingleEntryShouldBeReturned()
09:43:48.924 [WARNING] ^
09:43:48.924 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiveConfigurationTest.java:66: warning: no comment
09:43:48.924 [WARNING] public void addingThreeEntriesShouldBeReturnedInInsertOrder()
09:43:48.924 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiveConfigurationTest.java:57: warning: no comment
09:43:48.925 [WARNING] public void addingTwoEntriesShouldBeReturnedInInsertOrder()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiveConfigurationTest.java:39: warning: no comment
09:43:48.925 [WARNING] public void before()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:67: warning: no comment
09:43:48.925 [WARNING] public class MavenArchiverTest
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:1425: warning: no comment
09:43:48.925 [WARNING] public Manifest getJarFileManifest( File jarFile )
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:762: warning: no comment
09:43:48.925 [WARNING] public void shouldCreateArchiveCustomerLayoutSimple()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:834: warning: no comment
09:43:48.925 [WARNING] public void shouldCreateArchiveCustomLayoutRepository()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:874: warning: no comment
09:43:48.925 [WARNING] public void shouldCreateArchiveCustomLayoutRepositoryNonUnique()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:798: warning: no comment
09:43:48.925 [WARNING] public void shouldCreateArchiveCustomLayoutSimpleNonUnique()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:914: warning: no comment
09:43:48.925 [WARNING] public void shouldCreateArchiveWithSimpleClassPathLayoutUsingDefaults()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:727: warning: no comment
09:43:48.925 [WARNING] public void shouldCreateArchiveWithSimpleClassPathLayoutWhileSettingSimpleLayoutExplicit()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:407: warning: no comment
09:43:48.925 [WARNING] public void testCarriageReturnInManifestEntry()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:984: warning: no comment
09:43:48.925 [WARNING] public void testCustomClassPathValue()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:1059: warning: no comment
09:43:48.925 [WARNING] public void testCustomClassPathValue_WithSnapshotForcingBaseVersion()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:1022: warning: no comment
09:43:48.925 [WARNING] public void testCustomClassPathValue_WithSnapshotResolvedVersion()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:1133: warning: no comment
09:43:48.925 [WARNING] public void testCustomPomProperties()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:343: warning: no comment
09:43:48.925 [WARNING] public void testDashesInClassPath_MSHARED_134()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:373: warning: no comment
09:43:48.925 [WARNING] public void testDashesInClassPath_MSHARED_182()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:627: warning: no comment
09:43:48.925 [WARNING] public void testDefaultClassPathValue()
09:43:48.925 [WARNING] ^
09:43:48.925 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:661: warning: no comment
09:43:48.926 [WARNING] public void testDefaultClassPathValue_WithSnapshot()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:1096: warning: no comment
09:43:48.926 [WARNING] public void testDefaultPomProperties()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:439: warning: no comment
09:43:48.926 [WARNING] public void testDeprecatedCreateArchiveAPI()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:306: warning: no comment
09:43:48.926 [WARNING] public void testGenerateImplementationVersionForMANIFESTMF()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:108: warning: no comment
09:43:48.926 [WARNING] public void testGetManifestExtensionList()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:84: warning: no comment
09:43:48.926 [WARNING] public void testInvalidModuleNames()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:498: warning: no comment
09:43:48.926 [WARNING] public void testManifestEntries()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:598: warning: no comment
09:43:48.926 [WARNING] public void testManifestSections()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:568: warning: no comment
09:43:48.926 [WARNING] public void testManifestWithInvalidAutomaticModuleNameThrowsOnCreateArchive()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:690: warning: no comment
09:43:48.926 [WARNING] public void testMavenRepoClassPathValue()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:947: warning: no comment
09:43:48.926 [WARNING] public void testMavenRepoClassPathValue_WithSnapshot()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:472: warning: no comment
09:43:48.926 [WARNING] public void testMinimalManifestEntries()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:192: warning: no comment
09:43:48.926 [WARNING] public void testMultiClassPath()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:281: warning: no comment
09:43:48.926 [WARNING] public void testNotGenerateImplementationVersionForMANIFESTMF()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:1435: warning: no comment
09:43:48.926 [WARNING] public void testParseOutputTimestamp()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:243: warning: no comment
09:43:48.926 [WARNING] public void testRecreation()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] /home/jorsol/code/github.com/jorsol/maven-archiver/src/test/java/org/apache/maven/archiver/MavenArchiverTest.java:97: warning: no comment
09:43:48.926 [WARNING] public void testValidModuleNames()
09:43:48.926 [WARNING] ^
09:43:48.926 [WARNING] 43 warnings
09:43:48.974 [INFO] ------------------------------------------------------------------------
09:43:48.974 [INFO] BUILD SUCCESS
09:43:48.974 [INFO] ------------------------------------------------------------------------
```
Anyway, thanks for the small workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] slachiewicz commented on pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #21:
URL: https://github.com/apache/maven-archiver/pull/21#issuecomment-1107452806
I've marked only one class as public, all test should still be at package scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] slawekjaranowski commented on pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #21:
URL: https://github.com/apache/maven-archiver/pull/21#issuecomment-1107466714
I see ... but what if project contains only test cases ... without utils classes?
So maybe it is next report to remove .. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] slawekjaranowski commented on pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #21:
URL: https://github.com/apache/maven-archiver/pull/21#issuecomment-1107431395
> small workaround just to not be blocked here. I made public one of classes in tests :)
So when we will use Junit5 and all classes will package private javadoc will fail ...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] slachiewicz closed pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
URL: https://github.com/apache/maven-archiver/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] slachiewicz commented on pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #21:
URL: https://github.com/apache/maven-archiver/pull/21#issuecomment-1106848371
@slawekjaranowski same error locally if I run it as ` mvn --errors -DskipTests -P reporting site`
Generating "Test Javadoc" report --- maven-javadoc-plugin:3.3.2:test-javadoc
```
Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.11.0:site (default-site) on project maven-archiver: Error generating maven-javadoc-plugin:3.3.2:test-javadoc report:
[ERROR] Exit code: 1 - error: No public or protected classes found to document.
[ERROR] 1 error
[ERROR]
[ERROR] Command line was: /opt/homebrew/Cellar/openjdk/18.0.1/libexec/openjdk.jdk/Contents/Home/bin/javadoc @options @packages
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] slachiewicz commented on pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #21:
URL: https://github.com/apache/maven-archiver/pull/21#issuecomment-1106863801
small workaround just to not be blocked here. I made public one of classes in tests :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archiver] jorsol commented on pull request #21: [MSHARED-1003] - Require Maven 3.2.5+
Posted by GitBox <gi...@apache.org>.
jorsol commented on PR #21:
URL: https://github.com/apache/maven-archiver/pull/21#issuecomment-1106650534
Ok, I'm will investigate the error from CI, locally the site build works correctly, so it might be other issue from the pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org