[GitHub] [doris] morrySnow commented on a diff in pull request #20334: [feature](optimizer): support user defined variable

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #20334:
URL: https://github.com/apache/doris/pull/20334#discussion_r1217460606


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -989,7 +989,8 @@ public TExpr treeToThrift() {
             // Hack to ensure BE never sees TYPE_NULL. If an expr makes it this far without
             // being cast to a non-NULL type, the type doesn't matter and we can cast it
             // arbitrarily.
-            Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef);
+            Preconditions.checkState(this instanceof NullLiteral || this instanceof SlotRef
+                    || this instanceof VariableExpr);

Review Comment:
   why we could see VariableExpr here?



##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SetUserDefinedVar.java:
##########
@@ -0,0 +1,38 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+
+public class SetUserDefinedVar extends SetVar {
+    public SetUserDefinedVar(String variable, Expr value) {
+        super(SetType.USER, variable, value, SetVarType.SET_USER_DEFINED_VAR);
+    }
+
+    @Override
+    public void analyze(Analyzer analyzer) {
+        Expr expression = getValue();
+        if (expression instanceof NullLiteral) {
+            setResult(NullLiteral.create(ScalarType.NULL));
+        } else if (expression instanceof LiteralExpr) {
+            setResult((LiteralExpr) expression);

Review Comment:
   do we easy to support other expression? such as `1 + 1` or `@a + 1` or `concat(@4, "xxx")`?



##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SetUserDefinedVar.java:
##########
@@ -0,0 +1,38 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.catalog.ScalarType;
+
+public class SetUserDefinedVar extends SetVar {
+    public SetUserDefinedVar(String variable, Expr value) {
+        super(SetType.USER, variable, value, SetVarType.SET_USER_DEFINED_VAR);
+    }
+
+    @Override
+    public void analyze(Analyzer analyzer) {
+        Expr expression = getValue();
+        if (expression instanceof NullLiteral) {
+            setResult(NullLiteral.create(ScalarType.NULL));
+        } else if (expression instanceof LiteralExpr) {
+            setResult((LiteralExpr) expression);
+        } else {
+            //TODO : compute value from query statement

Review Comment:
   should we need to throw exception now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org