[GitHub] [pinot] mcvsubbu commented on a change in pull request #8280: [WIP][NOT_FOR_REVIEW] Expose consuming segment's offset lag through /consumingSegmentsInfo API

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #8280:
URL: https://github.com/apache/pinot/pull/8280#discussion_r818023036



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionLagInfo.java
##########
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.stream;
+
+public class PartitionLagInfo {
+  private String _offsetLag = "UNKNOWN";
+
+  public static PartitionLagInfo empty() {
+    return new PartitionLagInfo();
+  }
+
+  public String getOffsetLag() {
+    return _offsetLag;

Review comment:
       There should be an element of time in this. Not all offsets are numerical, so the underlying plugin can compute the time difference between the offsets presented.
   
   In Kafka the offset difference neither equates to time nor number of messages




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org