You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/28 04:38:23 UTC
[GitHub] [incubator-devlake] ppborah opened a new pull request, #2625: feat: add DirectoryOrCreate in k8s-deploy.yaml
ppborah opened a new pull request, #2625:
URL: https://github.com/apache/incubator-devlake/pull/2625
Required directory creation in k8s-workers through k8s-deploy.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] ppborah commented on pull request #2625: feat: add DirectoryOrCreate in k8s-deploy.yaml
Posted by GitBox <gi...@apache.org>.
ppborah commented on PR #2625:
URL: https://github.com/apache/incubator-devlake/pull/2625#issuecomment-1198338052
Thanks for the PR merge! 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] ppborah commented on pull request #2625: feat: add DirectoryOrCreate in k8s-deploy.yaml
Posted by GitBox <gi...@apache.org>.
ppborah commented on PR #2625:
URL: https://github.com/apache/incubator-devlake/pull/2625#issuecomment-1197971657
PS: Making some changes, please don't merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #2625: feat: add DirectoryOrCreate in k8s-deploy.yaml
Posted by GitBox <gi...@apache.org>.
klesh merged PR #2625:
URL: https://github.com/apache/incubator-devlake/pull/2625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #2625: feat: add DirectoryOrCreate in k8s-deploy.yaml
Posted by GitBox <gi...@apache.org>.
klesh commented on PR #2625:
URL: https://github.com/apache/incubator-devlake/pull/2625#issuecomment-1198780554
Thanks for your contribution 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #2625: feat: add DirectoryOrCreate in k8s-deploy.yaml
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #2625:
URL: https://github.com/apache/incubator-devlake/pull/2625#discussion_r931827726
##########
k8s-deploy.yaml:
##########
@@ -204,6 +204,10 @@ spec:
- name: config
mountPath: "/app/.env"
volumes:
+ - name: config
Review Comment:
The name is conflicting with the following one,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org