You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2011/12/21 00:23:32 UTC

[jira] [Created] (LUCENE-3661) move deletes under codec

move deletes under codec
------------------------

                 Key: LUCENE-3661
                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
             Project: Lucene - Java
          Issue Type: Task
    Affects Versions: 4.0
            Reporter: Robert Muir


After LUCENE-3631, this should be easier I think.

I haven't looked at it much myself but i'll play around a bit, but at a glance:
* SegmentReader to have Bits liveDocs instead of BitVector
* address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
* we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
* BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
* I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
* redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
* plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189208#comment-13189208 ] 

Robert Muir commented on LUCENE-3661:
-------------------------------------

I started working on this some before christmas break, and just merged it up to trunk.

Ill commit it to a branch (branches/lucene3661) in case anyone wants to help. 

I don't think I really got much done yet, but it would be nice to make our codec api 
more complete by including representation of deletions.
                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195604#comment-13195604 ] 

Uwe Schindler commented on LUCENE-3661:
---------------------------------------

One thing: Can we not split the BitVector and LiveDocs in 3.x and trunk? Just because the logic is inverse in 3.x (deletions instead of live docs). This would also make the LiveDocs in trunk always have a codec header, but not in 3.x?

Otherwise, looks great!
                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3661.patch
>
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195613#comment-13195613 ] 

Robert Muir commented on LUCENE-3661:
-------------------------------------

We could, I think it would be mostly duplicate code at this point.

But, like stored fields (which is also shared), its just another TODO we can do later.

Definitely needs not block this issue (its unrelated).

                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3661.patch
>
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195640#comment-13195640 ] 

Robert Muir commented on LUCENE-3661:
-------------------------------------

I'll open a followup issue (can be done in trunk after this is committed).

Just for reference, there are 3 bitvector versions that can be read:
unversioned/darkages: some 3.x versions
codec header version 0: some 3.x versions
codec header version 1: trunk

so trunk always writes a versioned codec header, even lucene 3.5 always writes 
a versioned codec header, but i think the 3.x codec must at least support
unversioned files still for e.g. 3.0 indexes.

also, under the same issue we could maybe remove bitvector completely and the 
codecs just use FastBitSet. there is no difference now that count() is unused.

This could be cleaner: just having different serialization forms for fastbitset.

                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3661.patch
>
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3661) move deletes under codec

Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3661:
--------------------------------

    Attachment: LUCENE-3661.patch

Here's a patch showing the differences between branch and trunk.

I think its ready: thanks to Mike for helping with a lot of the cleanup here.

                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3661.patch
>
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191422#comment-13191422 ] 

Robert Muir commented on LUCENE-3661:
-------------------------------------

So this is "working" in the branch (SimpleText deletes and stuff), but needs rounding out
before committing, e.g. the API should not be so horrible and some documentation and such.
                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195630#comment-13195630 ] 

Uwe Schindler commented on LUCENE-3661:
---------------------------------------

We should open issue, otherwise coomit that so I can work on splitting composite and atomic readers again!
                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3661.patch
>
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3661) move deletes under codec

Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3661.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
    
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3661.patch
>
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195595#comment-13195595 ] 

Robert Muir commented on LUCENE-3661:
-------------------------------------

and also Simon for helping track down a tricky bug involving docvalues... maybe we 
should open an issue later to try to make it more resilient just for future refactorings? 

                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3661.patch
>
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174000#comment-13174000 ] 

Michael McCandless commented on LUCENE-3661:
--------------------------------------------

This sounds like a great plan!  So then the use of BitVector is an impl detail to the codec...
                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3661) move deletes under codec

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195733#comment-13195733 ] 

Robert Muir commented on LUCENE-3661:
-------------------------------------

Merging this to trunk now...

We can use LUCENE-3613 issue for any remaining splitting of 4.x/3.x codec impls (stored fields, deletes).

                
> move deletes under codec
> ------------------------
>
>                 Key: LUCENE-3661
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3661
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3661.patch
>
>
> After LUCENE-3631, this should be easier I think.
> I haven't looked at it much myself but i'll play around a bit, but at a glance:
> * SegmentReader to have Bits liveDocs instead of BitVector
> * address the TODO in the IW-using ctors so that SegmentReader doesn't take a parent but just an existing core.
> * we need some type of minimal "MutableBits" or similar subinterface of bits. BitVector and maybe Fixed/OpenBitSet could implement it
> * BitVector becomes an impl detail and moves to codec (maybe we have a shared base class and split the 3.x/4.x up rather than the conditional backwards)
> * I think the invertAll should not be used by IndexWriter, instead we define the codec interface to say "give me a new MutableBits, by default all are set" ?
> * redundant internally-consistent checks in checkLiveCounts should be done in the codec impl instead of in SegmentReader.
> * plain text impl in SimpleText.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org