You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Greg Woolsey <gr...@gmail.com> on 2019/04/05 23:32:06 UTC
[VOTE] Apache POI 4.1.0 release (RC3)
I've prepared artifacts for Apache POI release 4.1.0 (RC3).
Notable changes since 4.0.1:
* Improved support/fixes for Java 9+ and IBM JVM
* New EMF renderer and support of SVG images in XSLF
* Security, stability and memory/resource handling improvements
* Various bug fixes across function and conditional format rule evaluation
* Upgrade to XMLBeans 3.1.0
* Upgrade to Bouncycastle 1.61
* Upgrade to Curvesapi 1.06
* Upgrade to Commons-Codec 1.12
* Upgrade to Commons-Collections4 4.3
* Upgrade to XMLSec 2.1.2
https://dist.apache.org/repos/dist/dev/poi/4.1.0-RC3/
All tests pass.
ASC signatures verify, key is in the KEYS file in /dist/dev/poi/.
SHA* hashes match files.
Latest regression run results looked good, Dominik was going to kick off
another (probably still running) to verify some last minute changes cleared
up some new errors found from augmented regression checks.
Please vote on these artifacts.
The vote is open until April 8, planning release announcement late that day.
I'm +1 at this point, contents match 4.0.1, with updated dependency
versions.
Greg
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Andreas Beeker <ki...@apache.org>.
Hi Greg,
here is my +1
thanks for your patience and for pushing this through - it will be easier the next time! ;)
I've tested it with the POI Visualizer and it looks good - although it only covers a minimal area of POI.
Looking through the files, I've noted two issues:
- apart of Nexus, remove the .md5/.sha1 files:
https://issues.apache.org/jira/browse/INFRA-14923?focusedCommentId=16589492&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16589492
- the apidocs are linked via an absolute link in apidocs/index.xml and we might want to also
rename the "dev" subdir to a versioned named. So basically you need to open the index.html
in the dev directory - I regard this as minor glitch ...
Best wishes,
Andi
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Tim Allison <ta...@apache.org>.
Sorry for being late to the game. I won’t have time to run regression tests
until Monday or so... thank you Dominik and Greg!
On Sat, Apr 6, 2019 at 4:27 AM Dominik Stadler <do...@gmx.at>
wrote:
> Hi Greg,
>
> thanks for running the release and removing all the obstacles on the way,
> always good if as many people as possible can run the releases.
>
> I compared contents of packages for 4.0.1 and 4.1.0, everything looks good.
> Had some trouble with running the mass regression tests, results should
> become available over the weekend, but as stated let's not delay the
> release because of it..
>
> +1
>
> Dominik.
>
> On Sat, Apr 6, 2019 at 1:32 AM Greg Woolsey <gr...@gmail.com>
> wrote:
>
> > I've prepared artifacts for Apache POI release 4.1.0 (RC3).
> >
> > Notable changes since 4.0.1:
> >
> > * Improved support/fixes for Java 9+ and IBM JVM
> > * New EMF renderer and support of SVG images in XSLF
> > * Security, stability and memory/resource handling improvements
> > * Various bug fixes across function and conditional format rule
> evaluation
> > * Upgrade to XMLBeans 3.1.0
> > * Upgrade to Bouncycastle 1.61
> > * Upgrade to Curvesapi 1.06
> > * Upgrade to Commons-Codec 1.12
> > * Upgrade to Commons-Collections4 4.3
> > * Upgrade to XMLSec 2.1.2
> >
> > https://dist.apache.org/repos/dist/dev/poi/4.1.0-RC3/
> >
> > All tests pass.
> > ASC signatures verify, key is in the KEYS file in /dist/dev/poi/.
> > SHA* hashes match files.
> >
> > Latest regression run results looked good, Dominik was going to kick off
> > another (probably still running) to verify some last minute changes
> cleared
> > up some new errors found from augmented regression checks.
> >
> > Please vote on these artifacts.
> >
> > The vote is open until April 8, planning release announcement late that
> > day.
> >
> > I'm +1 at this point, contents match 4.0.1, with updated dependency
> > versions.
> >
> > Greg
> >
>
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by "pj.fanning" <fa...@yahoo.com>.
Thanks Greg.
In my testing, I had to make a couple of small code changes to get things
working again but nothing big and this is an intermediate version upgrade so
that's expected.
+1
--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Dominik Stadler <do...@gmx.at>.
Hi Greg,
thanks for running the release and removing all the obstacles on the way,
always good if as many people as possible can run the releases.
I compared contents of packages for 4.0.1 and 4.1.0, everything looks good.
Had some trouble with running the mass regression tests, results should
become available over the weekend, but as stated let's not delay the
release because of it..
+1
Dominik.
On Sat, Apr 6, 2019 at 1:32 AM Greg Woolsey <gr...@gmail.com> wrote:
> I've prepared artifacts for Apache POI release 4.1.0 (RC3).
>
> Notable changes since 4.0.1:
>
> * Improved support/fixes for Java 9+ and IBM JVM
> * New EMF renderer and support of SVG images in XSLF
> * Security, stability and memory/resource handling improvements
> * Various bug fixes across function and conditional format rule evaluation
> * Upgrade to XMLBeans 3.1.0
> * Upgrade to Bouncycastle 1.61
> * Upgrade to Curvesapi 1.06
> * Upgrade to Commons-Codec 1.12
> * Upgrade to Commons-Collections4 4.3
> * Upgrade to XMLSec 2.1.2
>
> https://dist.apache.org/repos/dist/dev/poi/4.1.0-RC3/
>
> All tests pass.
> ASC signatures verify, key is in the KEYS file in /dist/dev/poi/.
> SHA* hashes match files.
>
> Latest regression run results looked good, Dominik was going to kick off
> another (probably still running) to verify some last minute changes cleared
> up some new errors found from augmented regression checks.
>
> Please vote on these artifacts.
>
> The vote is open until April 8, planning release announcement late that
> day.
>
> I'm +1 at this point, contents match 4.0.1, with updated dependency
> versions.
>
> Greg
>
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Tim Allison <ta...@apache.org>.
All,
Again, my apologies for being late to the game. I don't want to
stop the release. +0
Best,
Tim
On Mon, Apr 8, 2019 at 1:16 PM Greg Woolsey <gr...@gmail.com> wrote:
>
> It is my understanding these changes were part of what motivated the
> version change from initial 4.0.2 to 4.1.0, but that's not an area of code
> I'm familiar with.
>
> On Mon, Apr 8, 2019 at 6:07 AM Tim Allison <ta...@apache.org> wrote:
>
> > Are we ok with the backward incompatibilities in EMF...These are just
> > a few. I realize these classes are @Internal, and the updates look
> > great.
> >
> > HwmfRecord.getRecordType() -> getWmfRecordType()
> >
> > oap.hemf.record.AbstractHemfComment -> oap.hemf.record.hemf.Comment
> > oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
> > oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
> >
> > oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture
> >
> > On Sun, Apr 7, 2019 at 8:27 AM Yegor Kozlov <ye...@dinom.ru> wrote:
> > >
> > > +1
> > >
> > > Looks good to me
> > >
> > > сб, 6 апр. 2019 г., 2:32 Greg Woolsey <gr...@gmail.com>:
> > >
> > > > I've prepared artifacts for Apache POI release 4.1.0 (RC3).
> > > >
> > > > Notable changes since 4.0.1:
> > > >
> > > > * Improved support/fixes for Java 9+ and IBM JVM
> > > > * New EMF renderer and support of SVG images in XSLF
> > > > * Security, stability and memory/resource handling improvements
> > > > * Various bug fixes across function and conditional format rule
> > evaluation
> > > > * Upgrade to XMLBeans 3.1.0
> > > > * Upgrade to Bouncycastle 1.61
> > > > * Upgrade to Curvesapi 1.06
> > > > * Upgrade to Commons-Codec 1.12
> > > > * Upgrade to Commons-Collections4 4.3
> > > > * Upgrade to XMLSec 2.1.2
> > > >
> > > > https://dist.apache.org/repos/dist/dev/poi/4.1.0-RC3/
> > > >
> > > > All tests pass.
> > > > ASC signatures verify, key is in the KEYS file in /dist/dev/poi/.
> > > > SHA* hashes match files.
> > > >
> > > > Latest regression run results looked good, Dominik was going to kick
> > off
> > > > another (probably still running) to verify some last minute changes
> > cleared
> > > > up some new errors found from augmented regression checks.
> > > >
> > > > Please vote on these artifacts.
> > > >
> > > > The vote is open until April 8, planning release announcement late that
> > > > day.
> > > >
> > > > I'm +1 at this point, contents match 4.0.1, with updated dependency
> > > > versions.
> > > >
> > > > Greg
> > > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> > For additional commands, e-mail: dev-help@poi.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Greg Woolsey <gr...@gmail.com>.
It is my understanding these changes were part of what motivated the
version change from initial 4.0.2 to 4.1.0, but that's not an area of code
I'm familiar with.
On Mon, Apr 8, 2019 at 6:07 AM Tim Allison <ta...@apache.org> wrote:
> Are we ok with the backward incompatibilities in EMF...These are just
> a few. I realize these classes are @Internal, and the updates look
> great.
>
> HwmfRecord.getRecordType() -> getWmfRecordType()
>
> oap.hemf.record.AbstractHemfComment -> oap.hemf.record.hemf.Comment
> oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
> oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
>
> oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture
>
> On Sun, Apr 7, 2019 at 8:27 AM Yegor Kozlov <ye...@dinom.ru> wrote:
> >
> > +1
> >
> > Looks good to me
> >
> > сб, 6 апр. 2019 г., 2:32 Greg Woolsey <gr...@gmail.com>:
> >
> > > I've prepared artifacts for Apache POI release 4.1.0 (RC3).
> > >
> > > Notable changes since 4.0.1:
> > >
> > > * Improved support/fixes for Java 9+ and IBM JVM
> > > * New EMF renderer and support of SVG images in XSLF
> > > * Security, stability and memory/resource handling improvements
> > > * Various bug fixes across function and conditional format rule
> evaluation
> > > * Upgrade to XMLBeans 3.1.0
> > > * Upgrade to Bouncycastle 1.61
> > > * Upgrade to Curvesapi 1.06
> > > * Upgrade to Commons-Codec 1.12
> > > * Upgrade to Commons-Collections4 4.3
> > > * Upgrade to XMLSec 2.1.2
> > >
> > > https://dist.apache.org/repos/dist/dev/poi/4.1.0-RC3/
> > >
> > > All tests pass.
> > > ASC signatures verify, key is in the KEYS file in /dist/dev/poi/.
> > > SHA* hashes match files.
> > >
> > > Latest regression run results looked good, Dominik was going to kick
> off
> > > another (probably still running) to verify some last minute changes
> cleared
> > > up some new errors found from augmented regression checks.
> > >
> > > Please vote on these artifacts.
> > >
> > > The vote is open until April 8, planning release announcement late that
> > > day.
> > >
> > > I'm +1 at this point, contents match 4.0.1, with updated dependency
> > > versions.
> > >
> > > Greg
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Greg Woolsey <gr...@gmail.com>.
Vote passes with 5 +1 and 1 +0 votes.
I'll begin the release process. Thank you all for your help, checks, and
discussion.
Greg
On Mon, Apr 8, 2019 at 2:12 PM Tim Allison <ta...@apache.org> wrote:
> Hi Andi,
>
> Y, to be clear, I really like what you’ve done and it is all a bunch
> cleaner than my earlier stuff; I wasn’t at all questioning the design. The
> question was more to back compat. There was quite a bit of red when I made
> the upgrade and before I modernized our code on Tika.
>
> As long as we’re all on board, off we go!
>
> As to my two recent commits, please let me know if there are better options
> for 4.1.1.
>
> Thank you!
>
> Cheers,
>
> Tim
>
> On Mon, Apr 8, 2019 at 4:55 PM Andreas Beeker <ki...@apache.org>
> wrote:
>
> > Hi Tim,
> >
> > I've made that changes on purpose, as I wanted to make the EMF API
> similar
> > to the WMF one.
> >
> > > oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture
> > All (?) our user models are called by their content and being similar to
> > WMF, I had to rename the class.
> >
> > > HwmfRecord.getRecordType() -> getWmfRecordType()
> > The EMF records extends the WMF records, so this makes it more clear what
> > kind of record type to ask for.
> >
> > > oap.hemf.record.AbstractHemfComment -> oap.hemf.record.hemf.Comment
> > > oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
> > >
> > As both sets (emf and emfplus) contain quite a few records, I've decided
> > to split their packages.
> >
> > I'm now looking at the other (not yet resolved) issues you opened.
> >
> > Andi
> >
> >
> >
>
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Tim Allison <ta...@apache.org>.
Hi Andi,
Y, to be clear, I really like what you’ve done and it is all a bunch
cleaner than my earlier stuff; I wasn’t at all questioning the design. The
question was more to back compat. There was quite a bit of red when I made
the upgrade and before I modernized our code on Tika.
As long as we’re all on board, off we go!
As to my two recent commits, please let me know if there are better options
for 4.1.1.
Thank you!
Cheers,
Tim
On Mon, Apr 8, 2019 at 4:55 PM Andreas Beeker <ki...@apache.org> wrote:
> Hi Tim,
>
> I've made that changes on purpose, as I wanted to make the EMF API similar
> to the WMF one.
>
> > oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture
> All (?) our user models are called by their content and being similar to
> WMF, I had to rename the class.
>
> > HwmfRecord.getRecordType() -> getWmfRecordType()
> The EMF records extends the WMF records, so this makes it more clear what
> kind of record type to ask for.
>
> > oap.hemf.record.AbstractHemfComment -> oap.hemf.record.hemf.Comment
> > oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
> >
> As both sets (emf and emfplus) contain quite a few records, I've decided
> to split their packages.
>
> I'm now looking at the other (not yet resolved) issues you opened.
>
> Andi
>
>
>
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Tim Allison <ta...@apache.org>.
On Mon, Apr 8, 2019 at 4:55 PM Andreas Beeker <ki...@apache.org> wrote:
> Hi Tim,
>
> I've made that changes on purpose, as I wanted to make the EMF API similar
> to the WMF one.
>
> > oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture
> All (?) our user models are called by their content and being similar to
> WMF, I had to rename the class.
>
> > HwmfRecord.getRecordType() -> getWmfRecordType()
> The EMF records extends the WMF records, so this makes it more clear what
> kind of record type to ask for.
>
> > oap.hemf.record.AbstractHemfComment -> oap.hemf.record.hemf.Comment
> > oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
> >
> As both sets (emf and emfplus) contain quite a few records, I've decided
> to split their packages.
>
> I'm now looking at the other (not yet resolved) issues you opened.
>
> Andi
>
>
>
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Andreas Beeker <ki...@apache.org>.
Hi Tim,
I've made that changes on purpose, as I wanted to make the EMF API similar to the WMF one.
> oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture
All (?) our user models are called by their content and being similar to WMF, I had to rename the class.
> HwmfRecord.getRecordType() -> getWmfRecordType()
The EMF records extends the WMF records, so this makes it more clear what kind of record type to ask for.
> oap.hemf.record.AbstractHemfComment -> oap.hemf.record.hemf.Comment
> oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
>
As both sets (emf and emfplus) contain quite a few records, I've decided to split their packages.
I'm now looking at the other (not yet resolved) issues you opened.
Andi
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Tim Allison <ta...@apache.org>.
Are we ok with the backward incompatibilities in EMF...These are just
a few. I realize these classes are @Internal, and the updates look
great.
HwmfRecord.getRecordType() -> getWmfRecordType()
oap.hemf.record.AbstractHemfComment -> oap.hemf.record.hemf.Comment
oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
oap.hemf.record.HemfRecord -> oap.h.r.emf.HemfRecord
oap.hemf.extractor.HemfExtractor -> oap.hemf.usermodel.HemfPicture
On Sun, Apr 7, 2019 at 8:27 AM Yegor Kozlov <ye...@dinom.ru> wrote:
>
> +1
>
> Looks good to me
>
> сб, 6 апр. 2019 г., 2:32 Greg Woolsey <gr...@gmail.com>:
>
> > I've prepared artifacts for Apache POI release 4.1.0 (RC3).
> >
> > Notable changes since 4.0.1:
> >
> > * Improved support/fixes for Java 9+ and IBM JVM
> > * New EMF renderer and support of SVG images in XSLF
> > * Security, stability and memory/resource handling improvements
> > * Various bug fixes across function and conditional format rule evaluation
> > * Upgrade to XMLBeans 3.1.0
> > * Upgrade to Bouncycastle 1.61
> > * Upgrade to Curvesapi 1.06
> > * Upgrade to Commons-Codec 1.12
> > * Upgrade to Commons-Collections4 4.3
> > * Upgrade to XMLSec 2.1.2
> >
> > https://dist.apache.org/repos/dist/dev/poi/4.1.0-RC3/
> >
> > All tests pass.
> > ASC signatures verify, key is in the KEYS file in /dist/dev/poi/.
> > SHA* hashes match files.
> >
> > Latest regression run results looked good, Dominik was going to kick off
> > another (probably still running) to verify some last minute changes cleared
> > up some new errors found from augmented regression checks.
> >
> > Please vote on these artifacts.
> >
> > The vote is open until April 8, planning release announcement late that
> > day.
> >
> > I'm +1 at this point, contents match 4.0.1, with updated dependency
> > versions.
> >
> > Greg
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Yegor Kozlov <ye...@dinom.ru>.
+1
Looks good to me
сб, 6 апр. 2019 г., 2:32 Greg Woolsey <gr...@gmail.com>:
> I've prepared artifacts for Apache POI release 4.1.0 (RC3).
>
> Notable changes since 4.0.1:
>
> * Improved support/fixes for Java 9+ and IBM JVM
> * New EMF renderer and support of SVG images in XSLF
> * Security, stability and memory/resource handling improvements
> * Various bug fixes across function and conditional format rule evaluation
> * Upgrade to XMLBeans 3.1.0
> * Upgrade to Bouncycastle 1.61
> * Upgrade to Curvesapi 1.06
> * Upgrade to Commons-Codec 1.12
> * Upgrade to Commons-Collections4 4.3
> * Upgrade to XMLSec 2.1.2
>
> https://dist.apache.org/repos/dist/dev/poi/4.1.0-RC3/
>
> All tests pass.
> ASC signatures verify, key is in the KEYS file in /dist/dev/poi/.
> SHA* hashes match files.
>
> Latest regression run results looked good, Dominik was going to kick off
> another (probably still running) to verify some last minute changes cleared
> up some new errors found from augmented regression checks.
>
> Please vote on these artifacts.
>
> The vote is open until April 8, planning release announcement late that
> day.
>
> I'm +1 at this point, contents match 4.0.1, with updated dependency
> versions.
>
> Greg
>
Re: [VOTE] Apache POI 4.1.0 release (RC3)
Posted by Dominik Stadler <do...@gmx.at>.
Hi,
regression test results are in, there is a strange NoClassDefFound error
which I think is not relevant and caused by the way the jars were built, I
started a re-run to check. Otherwise I did not spot any new difference to
4.0.x, most of them are due to new features or new checks in the testing.
- 4.0.1-RC2 to 4.1.0-RC2
<http://people.apache.org/~centic/poi_regression/reports/index401RC2to410RC2.html>
- 4.1.0-RC2-All
<http://people.apache.org/~centic/poi_regression/reportsAll/index401RC2to410RC2.html>
Dominik.
On Sat, Apr 6, 2019 at 1:32 AM Greg Woolsey <gr...@gmail.com> wrote:
> I've prepared artifacts for Apache POI release 4.1.0 (RC3).
>
> Notable changes since 4.0.1:
>
> * Improved support/fixes for Java 9+ and IBM JVM
> * New EMF renderer and support of SVG images in XSLF
> * Security, stability and memory/resource handling improvements
> * Various bug fixes across function and conditional format rule evaluation
> * Upgrade to XMLBeans 3.1.0
> * Upgrade to Bouncycastle 1.61
> * Upgrade to Curvesapi 1.06
> * Upgrade to Commons-Codec 1.12
> * Upgrade to Commons-Collections4 4.3
> * Upgrade to XMLSec 2.1.2
>
> https://dist.apache.org/repos/dist/dev/poi/4.1.0-RC3/
>
> All tests pass.
> ASC signatures verify, key is in the KEYS file in /dist/dev/poi/.
> SHA* hashes match files.
>
> Latest regression run results looked good, Dominik was going to kick off
> another (probably still running) to verify some last minute changes cleared
> up some new errors found from augmented regression checks.
>
> Please vote on these artifacts.
>
> The vote is open until April 8, planning release announcement late that
> day.
>
> I'm +1 at this point, contents match 4.0.1, with updated dependency
> versions.
>
> Greg
>