You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/15 21:49:01 UTC
[GitHub] [incubator-superset] ktmud opened a new issue #11292: Non-chart owners should not be able to edit chart properties
ktmud opened a new issue #11292:
URL: https://github.com/apache/incubator-superset/issues/11292
Currently when users edit a chart they are not an owner of, they can still change things in the Edit Properties modal, but when they save, it will report "an error occurred". We should either hide the Edit icon or disable all inputs.
#### Screenshots
#### How to reproduce the bug
1. Edit a chart that you are not an owner of
2. Edit chart properties and change the owner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11292: Non-chart owners should not be able to edit chart properties
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11292:
URL: https://github.com/apache/incubator-superset/issues/11292#issuecomment-709608663
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.89. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #11292: Non-chart owners should not be able to edit chart properties
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11292:
URL: https://github.com/apache/incubator-superset/issues/11292#issuecomment-714191979
I opened https://github.com/apache/incubator-superset/pull/11381 which is not a perfect fix, but it should make things a little less confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai closed issue #11292: Non-chart owners should not be able to edit chart properties
Posted by GitBox <gi...@apache.org>.
nytai closed issue #11292:
URL: https://github.com/apache/incubator-superset/issues/11292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org