You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/19 18:27:15 UTC
Review Request 70897: Supported suppressedRoles in updateFramework()
in V0 Java bindings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70897/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9793
https://issues.apache.org/jira/browse/MESOS-9793
Repository: mesos
Description
-------
Supported suppressedRoles in updateFramework() in V0 Java bindings.
Diffs
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp b47976376ce49b518d97a702a794b704cb79dcdd
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4
src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f
Diff: https://reviews.apache.org/r/70897/diff/1/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70815/
Thanks,
Andrei Sekretenko
Re: Review Request 70897: Supported suppressedRoles in
updateFramework() in V0 Java bindings.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70897/
-----------------------------------------------------------
(Updated June 26, 2019, 3:32 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9793
https://issues.apache.org/jira/browse/MESOS-9793
Repository: mesos
Description
-------
Supported suppressedRoles in updateFramework() in V0 Java bindings.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a21aca23cbef27b3c54bf1ae5834cbb457608130
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4
src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f
Diff: https://reviews.apache.org/r/70897/diff/3/
Changes: https://reviews.apache.org/r/70897/diff/2-3/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70815/
Thanks,
Andrei Sekretenko
Re: Review Request 70897: Supported suppressedRoles in
updateFramework() in V0 Java bindings.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70897/#review216125
-----------------------------------------------------------
Fix it, then Ship it!
src/java/src/org/apache/mesos/MesosSchedulerDriver.java
Line 301 (original), 301-302 (patched)
<https://reviews.apache.org/r/70897/#comment303131>
what's with the wrapping here?
- Benjamin Mahler
On June 25, 2019, 3:29 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70897/
> -----------------------------------------------------------
>
> (Updated June 25, 2019, 3:29 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported suppressedRoles in updateFramework() in V0 Java bindings.
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a21aca23cbef27b3c54bf1ae5834cbb457608130
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4
> src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f
>
>
> Diff: https://reviews.apache.org/r/70897/diff/2/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70815/
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70897: Supported suppressedRoles in
updateFramework() in V0 Java bindings.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70897/
-----------------------------------------------------------
(Updated June 25, 2019, 3:29 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-9793
https://issues.apache.org/jira/browse/MESOS-9793
Repository: mesos
Description
-------
Supported suppressedRoles in updateFramework() in V0 Java bindings.
Diffs (updated)
-----
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp a21aca23cbef27b3c54bf1ae5834cbb457608130
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4
src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f
Diff: https://reviews.apache.org/r/70897/diff/2/
Changes: https://reviews.apache.org/r/70897/diff/1-2/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70815/
Thanks,
Andrei Sekretenko