You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/28 22:21:03 UTC
[GitHub] [beam] AnandInguva opened a new pull request, #22503: Change _build import from setuptools to distutils
AnandInguva opened a new pull request, #22503:
URL: https://github.com/apache/beam/pull/22503
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kileys commented on pull request #22503: Change _build import from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
kileys commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198748435
@AnandInguva Could you create a cherry-pick PR for the new release-2.41.0 branch? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #22503: Change _build import from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #22503:
URL: https://github.com/apache/beam/pull/22503#discussion_r932727199
##########
sdks/python/apache_beam/examples/complete/juliaset/setup.py:
##########
@@ -30,7 +30,8 @@
import subprocess
import setuptools
-from setuptools.command.build import build as _build # type: ignore
+
+from distutils.command.build import build as _build # isort:skip
Review Comment:
Add comments why this is has to be skipped so that somebody doesn't try to clean it up.
##########
sdks/python/apache_beam/examples/complete/juliaset/setup.py:
##########
@@ -30,7 +30,8 @@
import subprocess
import setuptools
-from setuptools.command.build import build as _build # type: ignore
+
+from distutils.command.build import build as _build # isort:skip
Review Comment:
Add comments why this isort has to be skipped so that somebody doesn't try to clean it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #22503: Change _build import from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1199789078
Postcommit & Lint passed: https://ci-beam.apache.org/job/beam_PostCommit_Python39_PR/39/ , other suites not affected, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22503: Change build from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198392572
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on a diff in pull request #22503: Change _build import from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #22503:
URL: https://github.com/apache/beam/pull/22503#discussion_r932871547
##########
sdks/python/apache_beam/examples/complete/juliaset/setup.py:
##########
@@ -30,7 +30,8 @@
import subprocess
import setuptools
-from setuptools.command.build import build as _build # type: ignore
+
+from distutils.command.build import build as _build # isort:skip
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn closed pull request #22503: Change _build import from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
tvalentyn closed pull request #22503: Change _build import from setuptools to distutils
URL: https://github.com/apache/beam/pull/22503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #22503: Change build from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198243510
# [Codecov](https://codecov.io/gh/apache/beam/pull/22503?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22503](https://codecov.io/gh/apache/beam/pull/22503?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cf4af4) into [master](https://codecov.io/gh/apache/beam/commit/b0b9c6802552f06e506a4a78e68a3a3ddfbef343?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0b9c68) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #22503 +/- ##
==========================================
- Coverage 74.17% 74.16% -0.01%
==========================================
Files 706 706
Lines 93229 93229
==========================================
- Hits 69152 69145 -7
- Misses 22809 22816 +7
Partials 1268 1268
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.53% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/22503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...on/apache\_beam/examples/complete/juliaset/setup.py](https://codecov.io/gh/apache/beam/pull/22503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvc2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/22503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/22503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `78.26% <0.00%> (-1.45%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/22503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.06% <0.00%> (-1.33%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/22503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.05% <0.00%> (-0.39%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/22503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.02% <0.00%> (+0.74%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a diff in pull request #22503: Change _build import from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #22503:
URL: https://github.com/apache/beam/pull/22503#discussion_r932727199
##########
sdks/python/apache_beam/examples/complete/juliaset/setup.py:
##########
@@ -30,7 +30,8 @@
import subprocess
import setuptools
-from setuptools.command.build import build as _build # type: ignore
+
+from distutils.command.build import build as _build # isort:skip
Review Comment:
Add comments why isort has to be skipped so that somebody doesn't try to clean it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22503: Change build from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198394817
https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/542/ and https://ci-beam.apache.org/job/beam_PostCommit_Python39_PR/39.
This PR fixes https://ci-beam.apache.org/job/beam_PostCommit_Python39_PR/39/testReport/apache_beam.examples.complete.juliaset.juliaset.juliaset_test_it/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #22503: Change _build import from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
tvalentyn merged PR #22503:
URL: https://github.com/apache/beam/pull/22503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22503: Change build from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198207449
Run Python 3.8 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22503: Change build from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198207669
Run Python 3.9 PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22503: Change build from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198389627
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22503: Change build from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198391055
R: @apilloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22503: Change _build import from setuptools to distutils
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22503:
URL: https://github.com/apache/beam/pull/22503#issuecomment-1198634510
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org