[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #742: fix pyarrow type id mapping in `python` crate

[GitBox <gi...@apache.org>]

Jimexist commented on a change in pull request #742:
URL: https://github.com/apache/arrow-datafusion/pull/742#discussion_r671817228



##########
File path: python/src/types.rs
##########
@@ -48,24 +48,13 @@ fn data_type_id(id: &i32) -> Result<DataType, errors::DataFusionError> {
         7 => DataType::Int32,
         8 => DataType::UInt64,
         9 => DataType::Int64,
-
         10 => DataType::Float16,
         11 => DataType::Float32,
         12 => DataType::Float64,
-
-        //13 => DataType::Decimal,
-
-        // 14 => DataType::Date32(),
-        // 15 => DataType::Date64(),
-        // 16 => DataType::Timestamp(),
-        // 17 => DataType::Time32(),
-        // 18 => DataType::Time64(),
-        // 19 => DataType::Duration()
-        20 => DataType::Binary,
-        21 => DataType::Utf8,
-        22 => DataType::LargeBinary,
-        23 => DataType::LargeUtf8,
-
+        13 => DataType::Utf8,

Review comment:
       previously it'll throw because `pa.string()` is with `id` 13, not 20




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org