[GitHub] [hive] szlta commented on a change in pull request #909: HIVE-22821

[GitBox <gi...@apache.org>]

szlta commented on a change in pull request #909: HIVE-22821
URL: https://github.com/apache/hive/pull/909#discussion_r388197920
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
 ##########
 @@ -221,6 +227,9 @@ public void debugDumpShort(StringBuilder sb) {
         metadataCache, dataCache, bufferManagerOrc, conf, cacheMetrics, ioMetrics, tracePool);
     this.genericCvp = isEncodeEnabled ? new GenericColumnVectorProducer(
         serdeCache, bufferManagerGeneric, conf, cacheMetrics, ioMetrics, tracePool) : null;
+    proactiveEvictionExecutor = Executors.newSingleThreadExecutor(
 
 Review comment:
   I guess I just wanted to make sure that this operation is completely decoupled from the rest of threads.
   On daemon side you're right we'd be in an RPC handler thread while doing this eviction. My idea was that this request should return as fast as possible and don't even interfere with the RPC threads. Hence the void return value btw.
   
   On HS2 side in ProactiveEviction we already use an executor service to send the eviction request. 
    So it's decoupled on HS2 too. If you feel that's enough I'll remove the additional async part on the daemon side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org