[GitHub] [druid] loquisgon commented on a change in pull request #11941: AWS "Data read has a different length than the expected" error should reset stream and try again

[GitBox <gi...@apache.org>]

loquisgon commented on a change in pull request #11941:
URL: https://github.com/apache/druid/pull/11941#discussion_r751909293



##########
File path: extensions-core/s3-extensions/src/test/java/org/apache/druid/data/input/s3/S3InputSourceTest.java
##########
@@ -535,6 +539,48 @@ public void testReader() throws IOException
     EasyMock.verify(S3_CLIENT);
   }
 
+  @Test(expected = SdkClientException.class)
+  public void testReaderRetriesOnSdkClientExceptionButNeverSucceedsThenThrows() throws Exception

Review comment:
       This tests the new custom resettable condition for S3Entity. However this test is fairly time consuming since it retries 10 times, the default. I found no easy way to avoid the 10 retries due to the structure of the code. Let me know if anyone can think of something else.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org