You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by gqshen <gq...@apache.org> on 2015/04/08 10:31:46 UTC
[VOTE] Release Sentry incubating version 1.5.0 (rc0)
This is the incubator release of Apache Sentry, version 1.5.0-incubating.
The list of fixed issues, added features and improvements can be found here:
https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
Tag to be voted on (release 1.5.0-rc0/SHA:
589ea2c36f7bbec2affbddf10c3320178fdec9bf):
https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
Sentry's KEYS containing the PGP key we used to sign the release:
http://www.apache.org/dist/incubator/sentry/KEYS
Note that this is a source only release and we are voting on the source:
tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
Vote will be opened for 72 hours.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Thank you for your prompt votes.
Respectfully,
Sentry 1.5.0 Release Manager (Guoquan Shen)
Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Posted by Arvind Prabhakar <ar...@apache.org>.
[X] +1 approve
* Verified signature/checksums
* Verified top level files
* Verified the tag
Regards,
Arvind Prabhakar
On Wed, Apr 8, 2015 at 1:31 AM, gqshen <gq...@apache.org> wrote:
> This is the incubator release of Apache Sentry, version 1.5.0-incubating.
>
> The list of fixed issues, added features and improvements can be found
> here:
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
>
> Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
>
> Tag to be voted on (release 1.5.0-rc0/SHA:
> 589ea2c36f7bbec2affbddf10c3320178fdec9bf):
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> Sentry's KEYS containing the PGP key we used to sign the release:
> http://www.apache.org/dist/incubator/sentry/KEYS
>
> Note that this is a source only release and we are voting on the source:
> tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
>
> Vote will be opened for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thank you for your prompt votes.
>
> Respectfully,
>
> Sentry 1.5.0 Release Manager (Guoquan Shen)
>
Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Posted by Lenni Kuff <ls...@cloudera.com>.
+1
- Full set of tests pass
- Verified upgrade script from 1.4 -> 1.5 on mysql db
Thanks,
Lenni
On Fri, Apr 10, 2015 at 4:19 PM, Prasad Mujumdar <pr...@cloudera.com>
wrote:
> +1
> Verified signature, checksum. No binary files in the distribution.
> Full build and RAT check passes.
> Unit tests passed.
>
> thanks
> Prasad
>
>
> On Thu, Apr 9, 2015 at 10:38 AM, Patrick Hunt <ph...@apache.org> wrote:
>
> > If they are generated files then it's ok.
> >
> > I'm +1 - the xsum/sig are valid, RAT runs clean (per the noted exception)
> > and the disclaimer, etc.. are correct.
> >
> > Patrick
> >
> > On Wed, Apr 8, 2015 at 10:37 AM, Prasad Mujumdar <pr...@cloudera.com>
> > wrote:
> >
> > > Hi Patrick,
> > >
> > > Thanks for the feedback!
> > >
> > > Apache Sentry build invokes RAT check by default and these scripts
> > scripts
> > > are excluded [1] from the check. The .sql files are used for creating
> > > schema for Sentry metadata. Some of these are generated by native DB
> > export
> > > tools and others by cherry-picking parts of the top level script (for
> > > upgrades). In fact we did have some of these files in the last 1.4.0
> > > release as well. There are other Apache projects like Apache Hive,
> which
> > > includes similar SQL files without license header [2].
> > >
> > > Given that the SQLs are generated using external tools and there's
> > already
> > > a precedence of using such files without a license header, do you still
> > > think we should add licenses in Sentry ?
> > >
> > > thanks
> > > Prasad
> > >
> > > [1] -
> > >
> >
> https://github.com/apache/incubator-sentry/blob/branch-1.5.0/pom.xml#L710
> > > [2] -
> > >
> >
> https://github.com/apache/hive/tree/trunk/metastore/scripts/upgrade/mysql
> > >
> > >
> > > On Wed, Apr 8, 2015 at 9:56 AM, Patrick Hunt <ph...@apache.org> wrote:
> > >
> > > > I'm -1 at the moment - there are a number of .sql files
> > > > in ./sentry-provider/sentry-provider-db/src/main/resources that are
> > > missing
> > > > license headers.
> > > >
> > > > Patrick
> > > >
> > > > On Wed, Apr 8, 2015 at 1:31 AM, gqshen <gq...@apache.org> wrote:
> > > >
> > > > > This is the incubator release of Apache Sentry, version
> > > 1.5.0-incubating.
> > > > >
> > > > > The list of fixed issues, added features and improvements can be
> > found
> > > > > here:
> > > > >
> > > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
> > > > >
> > > > > Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
> > > > >
> > > > > Tag to be voted on (release 1.5.0-rc0/SHA:
> > > > > 589ea2c36f7bbec2affbddf10c3320178fdec9bf):
> > > > >
> > > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> > > > > Sentry's KEYS containing the PGP key we used to sign the release:
> > > > > http://www.apache.org/dist/incubator/sentry/KEYS
> > > > >
> > > > > Note that this is a source only release and we are voting on the
> > > source:
> > > > > tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> > > > >
> > > > > Vote will be opened for 72 hours.
> > > > >
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove (and reason why)
> > > > >
> > > > > Thank you for your prompt votes.
> > > > >
> > > > > Respectfully,
> > > > >
> > > > > Sentry 1.5.0 Release Manager (Guoquan Shen)
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Posted by Prasad Mujumdar <pr...@cloudera.com>.
+1
Verified signature, checksum. No binary files in the distribution.
Full build and RAT check passes.
Unit tests passed.
thanks
Prasad
On Thu, Apr 9, 2015 at 10:38 AM, Patrick Hunt <ph...@apache.org> wrote:
> If they are generated files then it's ok.
>
> I'm +1 - the xsum/sig are valid, RAT runs clean (per the noted exception)
> and the disclaimer, etc.. are correct.
>
> Patrick
>
> On Wed, Apr 8, 2015 at 10:37 AM, Prasad Mujumdar <pr...@cloudera.com>
> wrote:
>
> > Hi Patrick,
> >
> > Thanks for the feedback!
> >
> > Apache Sentry build invokes RAT check by default and these scripts
> scripts
> > are excluded [1] from the check. The .sql files are used for creating
> > schema for Sentry metadata. Some of these are generated by native DB
> export
> > tools and others by cherry-picking parts of the top level script (for
> > upgrades). In fact we did have some of these files in the last 1.4.0
> > release as well. There are other Apache projects like Apache Hive, which
> > includes similar SQL files without license header [2].
> >
> > Given that the SQLs are generated using external tools and there's
> already
> > a precedence of using such files without a license header, do you still
> > think we should add licenses in Sentry ?
> >
> > thanks
> > Prasad
> >
> > [1] -
> >
> https://github.com/apache/incubator-sentry/blob/branch-1.5.0/pom.xml#L710
> > [2] -
> >
> https://github.com/apache/hive/tree/trunk/metastore/scripts/upgrade/mysql
> >
> >
> > On Wed, Apr 8, 2015 at 9:56 AM, Patrick Hunt <ph...@apache.org> wrote:
> >
> > > I'm -1 at the moment - there are a number of .sql files
> > > in ./sentry-provider/sentry-provider-db/src/main/resources that are
> > missing
> > > license headers.
> > >
> > > Patrick
> > >
> > > On Wed, Apr 8, 2015 at 1:31 AM, gqshen <gq...@apache.org> wrote:
> > >
> > > > This is the incubator release of Apache Sentry, version
> > 1.5.0-incubating.
> > > >
> > > > The list of fixed issues, added features and improvements can be
> found
> > > > here:
> > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
> > > >
> > > > Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
> > > >
> > > > Tag to be voted on (release 1.5.0-rc0/SHA:
> > > > 589ea2c36f7bbec2affbddf10c3320178fdec9bf):
> > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> > > > Sentry's KEYS containing the PGP key we used to sign the release:
> > > > http://www.apache.org/dist/incubator/sentry/KEYS
> > > >
> > > > Note that this is a source only release and we are voting on the
> > source:
> > > > tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> > > >
> > > > Vote will be opened for 72 hours.
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove (and reason why)
> > > >
> > > > Thank you for your prompt votes.
> > > >
> > > > Respectfully,
> > > >
> > > > Sentry 1.5.0 Release Manager (Guoquan Shen)
> > > >
> > >
> >
>
Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Posted by Patrick Hunt <ph...@apache.org>.
If they are generated files then it's ok.
I'm +1 - the xsum/sig are valid, RAT runs clean (per the noted exception)
and the disclaimer, etc.. are correct.
Patrick
On Wed, Apr 8, 2015 at 10:37 AM, Prasad Mujumdar <pr...@cloudera.com>
wrote:
> Hi Patrick,
>
> Thanks for the feedback!
>
> Apache Sentry build invokes RAT check by default and these scripts scripts
> are excluded [1] from the check. The .sql files are used for creating
> schema for Sentry metadata. Some of these are generated by native DB export
> tools and others by cherry-picking parts of the top level script (for
> upgrades). In fact we did have some of these files in the last 1.4.0
> release as well. There are other Apache projects like Apache Hive, which
> includes similar SQL files without license header [2].
>
> Given that the SQLs are generated using external tools and there's already
> a precedence of using such files without a license header, do you still
> think we should add licenses in Sentry ?
>
> thanks
> Prasad
>
> [1] -
> https://github.com/apache/incubator-sentry/blob/branch-1.5.0/pom.xml#L710
> [2] -
> https://github.com/apache/hive/tree/trunk/metastore/scripts/upgrade/mysql
>
>
> On Wed, Apr 8, 2015 at 9:56 AM, Patrick Hunt <ph...@apache.org> wrote:
>
> > I'm -1 at the moment - there are a number of .sql files
> > in ./sentry-provider/sentry-provider-db/src/main/resources that are
> missing
> > license headers.
> >
> > Patrick
> >
> > On Wed, Apr 8, 2015 at 1:31 AM, gqshen <gq...@apache.org> wrote:
> >
> > > This is the incubator release of Apache Sentry, version
> 1.5.0-incubating.
> > >
> > > The list of fixed issues, added features and improvements can be found
> > > here:
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
> > >
> > > Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
> > >
> > > Tag to be voted on (release 1.5.0-rc0/SHA:
> > > 589ea2c36f7bbec2affbddf10c3320178fdec9bf):
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> > > Sentry's KEYS containing the PGP key we used to sign the release:
> > > http://www.apache.org/dist/incubator/sentry/KEYS
> > >
> > > Note that this is a source only release and we are voting on the
> source:
> > > tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> > >
> > > Vote will be opened for 72 hours.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > Thank you for your prompt votes.
> > >
> > > Respectfully,
> > >
> > > Sentry 1.5.0 Release Manager (Guoquan Shen)
> > >
> >
>
Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Posted by Prasad Mujumdar <pr...@cloudera.com>.
Hi Patrick,
Thanks for the feedback!
Apache Sentry build invokes RAT check by default and these scripts scripts
are excluded [1] from the check. The .sql files are used for creating
schema for Sentry metadata. Some of these are generated by native DB export
tools and others by cherry-picking parts of the top level script (for
upgrades). In fact we did have some of these files in the last 1.4.0
release as well. There are other Apache projects like Apache Hive, which
includes similar SQL files without license header [2].
Given that the SQLs are generated using external tools and there's already
a precedence of using such files without a license header, do you still
think we should add licenses in Sentry ?
thanks
Prasad
[1] -
https://github.com/apache/incubator-sentry/blob/branch-1.5.0/pom.xml#L710
[2] -
https://github.com/apache/hive/tree/trunk/metastore/scripts/upgrade/mysql
On Wed, Apr 8, 2015 at 9:56 AM, Patrick Hunt <ph...@apache.org> wrote:
> I'm -1 at the moment - there are a number of .sql files
> in ./sentry-provider/sentry-provider-db/src/main/resources that are missing
> license headers.
>
> Patrick
>
> On Wed, Apr 8, 2015 at 1:31 AM, gqshen <gq...@apache.org> wrote:
>
> > This is the incubator release of Apache Sentry, version 1.5.0-incubating.
> >
> > The list of fixed issues, added features and improvements can be found
> > here:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
> >
> > Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
> >
> > Tag to be voted on (release 1.5.0-rc0/SHA:
> > 589ea2c36f7bbec2affbddf10c3320178fdec9bf):
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> > Sentry's KEYS containing the PGP key we used to sign the release:
> > http://www.apache.org/dist/incubator/sentry/KEYS
> >
> > Note that this is a source only release and we are voting on the source:
> > tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> >
> > Vote will be opened for 72 hours.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Thank you for your prompt votes.
> >
> > Respectfully,
> >
> > Sentry 1.5.0 Release Manager (Guoquan Shen)
> >
>
Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Posted by Patrick Hunt <ph...@apache.org>.
I'm -1 at the moment - there are a number of .sql files
in ./sentry-provider/sentry-provider-db/src/main/resources that are missing
license headers.
Patrick
On Wed, Apr 8, 2015 at 1:31 AM, gqshen <gq...@apache.org> wrote:
> This is the incubator release of Apache Sentry, version 1.5.0-incubating.
>
> The list of fixed issues, added features and improvements can be found
> here:
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
>
> Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
>
> Tag to be voted on (release 1.5.0-rc0/SHA:
> 589ea2c36f7bbec2affbddf10c3320178fdec9bf):
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> Sentry's KEYS containing the PGP key we used to sign the release:
> http://www.apache.org/dist/incubator/sentry/KEYS
>
> Note that this is a source only release and we are voting on the source:
> tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
>
> Vote will be opened for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thank you for your prompt votes.
>
> Respectfully,
>
> Sentry 1.5.0 Release Manager (Guoquan Shen)
>
Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Posted by Sean Mackrory <ma...@gmail.com>.
+1 (binding)
Checked checksums, contents of LICENSE, NOTICE, DISCLAIMER and general
tarball contents, ran build and tests. Encountered and filed SENTRY-698,
but I don't believe that's serious enough to warrant a -1 on the release,
especially if multiple others are not running out of memory.
On Tue, Apr 14, 2015 at 12:08 PM, Tom White <to...@gmail.com> wrote:
> +1
>
> Checked sigs/checksums, source tag, and the contents of LICENSE,
> NOTICE, DISCLAIMER.
>
> Tom
>
> On Wed, Apr 8, 2015 at 9:31 AM, gqshen <gq...@apache.org> wrote:
> > This is the incubator release of Apache Sentry, version 1.5.0-incubating.
> >
> > The list of fixed issues, added features and improvements can be found
> here:
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
> >
> > Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
> >
> > Tag to be voted on (release 1.5.0-rc0/SHA:
> > 589ea2c36f7bbec2affbddf10c3320178fdec9bf):
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> > Sentry's KEYS containing the PGP key we used to sign the release:
> > http://www.apache.org/dist/incubator/sentry/KEYS
> >
> > Note that this is a source only release and we are voting on the source:
> > tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> >
> > Vote will be opened for 72 hours.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Thank you for your prompt votes.
> >
> > Respectfully,
> >
> > Sentry 1.5.0 Release Manager (Guoquan Shen)
>
Re: [VOTE] Release Sentry incubating version 1.5.0 (rc0)
Posted by Tom White <to...@gmail.com>.
+1
Checked sigs/checksums, source tag, and the contents of LICENSE,
NOTICE, DISCLAIMER.
Tom
On Wed, Apr 8, 2015 at 9:31 AM, gqshen <gq...@apache.org> wrote:
> This is the incubator release of Apache Sentry, version 1.5.0-incubating.
>
> The list of fixed issues, added features and improvements can be found here:
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=5d96434653aa292dfd025c7baa876013e95a5a15;hb=refs/heads/branch-1.5.0
>
> Source files : http://people.apache.org/~gqshen/sentry-1.5.0-rc0/
>
> Tag to be voted on (release 1.5.0-rc0/SHA:
> 589ea2c36f7bbec2affbddf10c3320178fdec9bf):
> https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=commit;h=589ea2c36f7bbec2affbddf10c3320178fdec9bf
> Sentry's KEYS containing the PGP key we used to sign the release:
> http://www.apache.org/dist/incubator/sentry/KEYS
>
> Note that this is a source only release and we are voting on the source:
> tag=release-1.5.0-rc0, SHA=589ea2c36f7bbec2affbddf10c3320178fdec9bf
>
> Vote will be opened for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thank you for your prompt votes.
>
> Respectfully,
>
> Sentry 1.5.0 Release Manager (Guoquan Shen)