[GitHub] dgrove-oss commented on a change in pull request #185: add kube 1.10.1 and minikube 0.26 to test matrix

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #185: add kube 1.10.1 and minikube 0.26 to test matrix
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185#discussion_r182414413
 
 

 ##########
 File path: docs/setting_up_minikube/README.md
 ##########
 @@ -21,21 +21,29 @@ asdf plugin-add kubectl
 asdf plugin-add minikube
 ```
 
-### Install asdf plugin minikube@0.23.0 and kubectl@1.7.4
+### Install asdf plugin minikube and kubectl
+For example this will setup versions 0.26.0 and 1.10.1, check the versions that are supported in the Travis matric config [../.travis.yml](../.travis.yml#L7)
 ```
-asdf install kubectl 1.7.4
-asdf global kubectl 1.7.4
-asdf install minikube 0.23.0
-asdf global minikube 0.23.0
+asdf install minikube 0.26.0
+asdf global minikube 0.26.0
+asdf install kubectl 1.10.1
+asdf global kubectl 1.10.1
 ```
 
 ## Create the minikube VM
 You will want at least 4GB of memory and 2 CPUs for Minikube to run OpenWhisk.
 If you have a larger machine, you may want to provision more (especially more memory).
 
-Start Minikube with:
+Configure minikube and persiste config:
 
 Review comment:
   typo: persist
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services