You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2015/11/04 22:35:31 UTC

[GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9315#discussion_r43943063
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala ---
    @@ -374,7 +374,17 @@ abstract class DStream[T: ClassTag] (
        * Wrap a body of code such that the call site and operation scope
        * information are passed to the RDDs created in this body properly.
        */
    -  protected def createRDDWithLocalProperties[U](time: Time)(body: => U): U = {
    +  protected[streaming] def createRDDWithLocalProperties[U](time: Time)(body: => U): U = {
    --- End diff --
    
    mima only checks the binary signature. `protected[streaming]` doesn't change that. Both of them are just `public` in the jvm method signature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org