You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2017/06/21 21:35:49 UTC
Review Request 60312: GEODE-2804 Cache InetAddress if configure host
as ip string.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/
-----------------------------------------------------------
Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
Repository: geode
Description
-------
GEODE-2804 Cache InetAddress if configure host as ip string.
1. We keep configure host string in HostAddress class
2. We reuse InetsocketAddress if it is ipString.
3. Client has logic to retry thus we keep InetsocketAddress even if
it is not ip string.
GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
GEODE-2940 Now we don't validate configure host string on start. As
there is possibility that host may not available.
1. Earlier wan config were failing because of that. Now we just keep
those configure host string. And try this later.
Added unit tests for it.
Diffs
-----
geode-assembly/build.gradle 39bb542
geode-assembly/src/test/resources/expected_jars.txt 6260167
geode-core/build.gradle 7f34b4a
geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 070451c
geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 1572355
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java c6bef57
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 93fa9da
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 84d42cf
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java e9476b5
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 4f4881f
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 9169904
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
gradle/dependency-versions.properties 183dafc
Diff: https://reviews.apache.org/r/60312/diff/1/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review178937
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Line 107 (original), 110 (patched)
<https://reviews.apache.org/r/60312/#comment253272>
Your new parameter isn't listed in the useless javadoc of this method. I think you should delete the javadoc.
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java
Lines 40 (patched)
<https://reviews.apache.org/r/60312/#comment253274>
typo: InetSocketAddress, not InetScoketAddress
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java
Lines 72 (patched)
<https://reviews.apache.org/r/60312/#comment253273>
There must be a better name for this method. I thought it was a typo. Maybe getSocketInetAddressNoLookup or something else describing its function.
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
Lines 346 (patched)
<https://reviews.apache.org/r/60312/#comment253460>
You can use a lambda for Callable<Boolean>
() -> {
return source.getOnlineLocators().isEmpty();
}
- Bruce Schuchardt
On June 27, 2017, 1:04 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> -----------------------------------------------------------
>
> (Updated June 27, 2017, 1:04 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2804 Cache InetAddress if configure host as ip string.
>
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if
> it is not ip string.
>
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
>
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
>
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
>
> Added unit tests for it.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 39bb542
> geode-assembly/src/test/resources/expected_jars.txt 6260167
> geode-core/build.gradle 7f34b4a
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 53d401a
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java a4b3a50
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java da295ab
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java aff1938
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java bc3d708
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java 6b54170
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 92cfd96
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
> geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java 0efba01
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 88832ba
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 3cc3cfc
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
> geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
> gradle/dependency-versions.properties 6a730a4
>
>
> Diff: https://reviews.apache.org/r/60312/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review179219
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Lines 255 (patched)
<https://reviews.apache.org/r/60312/#comment253846>
What does `la` mean in this context? could we possibly use more a more meaningful variable name?
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Line 243 (original), 282 (patched)
<https://reviews.apache.org/r/60312/#comment253847>
`la` is not a meaningful variable name
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Line 274 (original), 312 (patched)
<https://reviews.apache.org/r/60312/#comment253848>
`la` not a meaningful variable name
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
Line 389 (original), 390 (patched)
<https://reviews.apache.org/r/60312/#comment253849>
I know this is legacy code, but what does `others` represent here? Not clear what this method is doing by just reading the method name
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java
Lines 269 (patched)
<https://reviews.apache.org/r/60312/#comment253853>
could we not just inline `isa` with `getInetSocketAddress(host,port)`
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java
Line 298 (original), 305 (patched)
<https://reviews.apache.org/r/60312/#comment253854>
`l` is not a meaningful variable name. Maybe `locator` is more meaningful?
- Udo Kohlmeyer
On June 28, 2017, 6:48 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 6:48 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2804 Cache InetAddress if configure host as ip string.
>
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if
> it is not ip string.
>
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
>
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
>
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
>
> Added unit tests for it.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 39bb542
> geode-assembly/src/test/resources/expected_jars.txt 6260167
> geode-core/build.gradle 7f34b4a
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 53d401a
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java a4b3a50
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java da295ab
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java aff1938
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java bc3d708
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java 6b54170
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 92cfd96
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
> geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java 0efba01
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 88832ba
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 3cc3cfc
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
> geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
> gradle/dependency-versions.properties 6a730a4
>
>
> Diff: https://reviews.apache.org/r/60312/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review179382
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On June 29, 2017, 3:27 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 3:27 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2804 Cache InetAddress if configure host as ip string.
>
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if
> it is not ip string.
>
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
>
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
>
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
>
> Added unit tests for it.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 39bb542
> geode-assembly/src/test/resources/expected_jars.txt 6260167
> geode-core/build.gradle 7f34b4a
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 53d401a
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java a4b3a50
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java da295ab
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java aff1938
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java bc3d708
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java 6b54170
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 92cfd96
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
> geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java 0efba01
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 88832ba
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 3cc3cfc
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
> geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
> gradle/dependency-versions.properties 6a730a4
>
>
> Diff: https://reviews.apache.org/r/60312/diff/3/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Latest diff
> https://reviews.apache.org/media/uploaded/files/2017/06/29/45369a6d-34d0-42dd-96bc-a1c009d00824__GEODE-2804v2.patch
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/
-----------------------------------------------------------
(Updated June 29, 2017, 10:27 p.m.)
Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
Changes
-------
Updated diff
Repository: geode
Description
-------
GEODE-2804 Cache InetAddress if configure host as ip string.
1. We keep configure host string in HostAddress class
2. We reuse InetsocketAddress if it is ipString.
3. Client has logic to retry thus we keep InetsocketAddress even if
it is not ip string.
GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
GEODE-2940 Now we don't validate configure host string on start. As
there is possibility that host may not available.
1. Earlier wan config were failing because of that. Now we just keep
those configure host string. And try this later.
Added unit tests for it.
Diffs
-----
geode-assembly/build.gradle 39bb542
geode-assembly/src/test/resources/expected_jars.txt 6260167
geode-core/build.gradle 7f34b4a
geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 53d401a
geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java a4b3a50
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java da295ab
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java aff1938
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java bc3d708
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java 6b54170
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 92cfd96
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java 0efba01
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 88832ba
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 3cc3cfc
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
gradle/dependency-versions.properties 6a730a4
Diff: https://reviews.apache.org/r/60312/diff/3/
Testing
-------
File Attachments (updated)
----------------
Latest diff
https://reviews.apache.org/media/uploaded/files/2017/06/29/45369a6d-34d0-42dd-96bc-a1c009d00824__GEODE-2804v2.patch
Thanks,
Hitesh Khamesra
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/
-----------------------------------------------------------
(Updated June 28, 2017, 6:48 p.m.)
Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
Changes
-------
Updated revied feedback
Repository: geode
Description
-------
GEODE-2804 Cache InetAddress if configure host as ip string.
1. We keep configure host string in HostAddress class
2. We reuse InetsocketAddress if it is ipString.
3. Client has logic to retry thus we keep InetsocketAddress even if
it is not ip string.
GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
GEODE-2940 Now we don't validate configure host string on start. As
there is possibility that host may not available.
1. Earlier wan config were failing because of that. Now we just keep
those configure host string. And try this later.
Added unit tests for it.
Diffs (updated)
-----
geode-assembly/build.gradle 39bb542
geode-assembly/src/test/resources/expected_jars.txt 6260167
geode-core/build.gradle 7f34b4a
geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 53d401a
geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java a4b3a50
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java da295ab
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java aff1938
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java bc3d708
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java 6b54170
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 92cfd96
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java 0efba01
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 88832ba
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 3cc3cfc
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
gradle/dependency-versions.properties 6a730a4
Diff: https://reviews.apache.org/r/60312/diff/3/
Changes: https://reviews.apache.org/r/60312/diff/2-3/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/
-----------------------------------------------------------
(Updated June 27, 2017, 8:04 p.m.)
Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
Changes
-------
Updated patch with latest develop
Repository: geode
Description
-------
GEODE-2804 Cache InetAddress if configure host as ip string.
1. We keep configure host string in HostAddress class
2. We reuse InetsocketAddress if it is ipString.
3. Client has logic to retry thus we keep InetsocketAddress even if
it is not ip string.
GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
GEODE-2940 Now we don't validate configure host string on start. As
there is possibility that host may not available.
1. Earlier wan config were failing because of that. Now we just keep
those configure host string. And try this later.
Added unit tests for it.
Diffs (updated)
-----
geode-assembly/build.gradle 39bb542
geode-assembly/src/test/resources/expected_jars.txt 6260167
geode-core/build.gradle 7f34b4a
geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 53d401a
geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java a4b3a50
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java da295ab
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java aff1938
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java bc3d708
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java 6b54170
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 92cfd96
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java 0efba01
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 88832ba
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 3cc3cfc
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
gradle/dependency-versions.properties 6a730a4
Diff: https://reviews.apache.org/r/60312/diff/2/
Changes: https://reviews.apache.org/r/60312/diff/1-2/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Galen O'Sullivan <go...@pivotal.io>.
> On June 27, 2017, 6:19 p.m., Galen O'Sullivan wrote:
> > The diff doesn't apply cleanly on develop on my machine. What's the base commit?
Or better, can you merge or rebase on develop please?
- Galen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review179009
-----------------------------------------------------------
On June 21, 2017, 9:35 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 9:35 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2804 Cache InetAddress if configure host as ip string.
>
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if
> it is not ip string.
>
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
>
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
>
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
>
> Added unit tests for it.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 39bb542
> geode-assembly/src/test/resources/expected_jars.txt 6260167
> geode-core/build.gradle 7f34b4a
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 070451c
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 1572355
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java c6bef57
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 93fa9da
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 84d42cf
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java e9476b5
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 4f4881f
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 9169904
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
> geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
> gradle/dependency-versions.properties 183dafc
>
>
> Diff: https://reviews.apache.org/r/60312/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Galen O'Sullivan <go...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review179009
-----------------------------------------------------------
The diff doesn't apply cleanly on develop on my machine. What's the base commit?
geode-assembly/build.gradle
Lines 143 (patched)
<https://reviews.apache.org/r/60312/#comment253398>
It's a nit, but it would be nice to remove trailing whitespace.
- Galen O'Sullivan
On June 21, 2017, 9:35 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 9:35 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2804 Cache InetAddress if configure host as ip string.
>
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if
> it is not ip string.
>
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
>
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
>
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
>
> Added unit tests for it.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 39bb542
> geode-assembly/src/test/resources/expected_jars.txt 6260167
> geode-core/build.gradle 7f34b4a
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 070451c
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 1572355
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java c6bef57
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 93fa9da
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 84d42cf
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java e9476b5
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 4f4881f
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 9169904
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
> geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
> gradle/dependency-versions.properties 183dafc
>
>
> Diff: https://reviews.apache.org/r/60312/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Alexander Murmann <am...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review178993
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Line 74 (original), 75 (patched)
<https://reviews.apache.org/r/60312/#comment253367>
Since we are changing the variable names anyway, could they get more human friendly, less abbreviated names to make reading easier?
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Lines 120 (patched)
<https://reviews.apache.org/r/60312/#comment253370>
Do we need that commented out code?
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java
Line 161 (original), 161 (patched)
<https://reviews.apache.org/r/60312/#comment253374>
would this be better communicated outside of the code?
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java
Lines 308 (patched)
<https://reviews.apache.org/r/60312/#comment253392>
Can you please remove the commented out code?
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
Line 280 (original), 307 (patched)
<https://reviews.apache.org/r/60312/#comment253385>
What do you think about renaming the example to indicate intend instead of having a comment. For example: test_DiscoverLocators_whenOneLocatorWasShutdown
This way you get the context even from the test output and it's in line with the example on line 340 which also states its intend in the example method name.
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
Lines 663 (patched)
<https://reviews.apache.org/r/60312/#comment253394>
Can you please remove the trailing whitespace?
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
Line 345 (original), 345 (patched)
<https://reviews.apache.org/r/60312/#comment253390>
With this gone the test has no expectations left. Is the implicit expectation now that nothing gets thrown or can the example be deleted? If we are testing that nothing gets thrown, can we either add a explicit expecation or rename the example to make that clear to the reader?
- Alexander Murmann
On June 21, 2017, 9:35 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 9:35 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2804 Cache InetAddress if configure host as ip string.
>
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if
> it is not ip string.
>
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
>
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
>
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
>
> Added unit tests for it.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 39bb542
> geode-assembly/src/test/resources/expected_jars.txt 6260167
> geode-core/build.gradle 7f34b4a
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 070451c
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 1572355
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java c6bef57
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 93fa9da
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 84d42cf
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java e9476b5
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 4f4881f
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 9169904
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
> geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
> gradle/dependency-versions.properties 183dafc
>
>
> Diff: https://reviews.apache.org/r/60312/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure
host as ip string.
Posted by Brian Rowe <br...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review178995
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Line 86 (original), 89 (patched)
<https://reviews.apache.org/r/60312/#comment253371>
Since you're poking around in here anyways, can you clean up the formatting here
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Line 106 (original), 109 (patched)
<https://reviews.apache.org/r/60312/#comment253373>
This doesn't appear to be the most useful javadoc ever, but at the very least you should add the new parameter to it.
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Lines 117 (patched)
<https://reviews.apache.org/r/60312/#comment253375>
Did you mean to leave this comment in?
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java
Line 161 (original), 161 (patched)
<https://reviews.apache.org/r/60312/#comment253391>
Looks like you wanted to ask Bruce about this, you probably shouldn't merge this comment.
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
Lines 235 (patched)
<https://reviews.apache.org/r/60312/#comment253396>
Can we remove all of the the this.<variable> calls in favor of just using <variable> directly? Failing that, can you change 225 and 226 to this.hostname for consistency.
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java
Lines 59 (patched)
<https://reviews.apache.org/r/60312/#comment253397>
Typo, s/loators/locators
geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java
Lines 308 (patched)
<https://reviews.apache.org/r/60312/#comment253399>
remove this
- Brian Rowe
On June 21, 2017, 9:35 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 9:35 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2804 Cache InetAddress if configure host as ip string.
>
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if
> it is not ip string.
>
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
>
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
>
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
>
> Added unit tests for it.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle 39bb542
> geode-assembly/src/test/resources/expected_jars.txt 6260167
> geode-core/build.gradle 7f34b4a
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 070451c
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 1572355
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java c6bef57
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 93fa9da
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 84d42cf
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/HostAddress.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java e9476b5
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 4f4881f
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 9169904
> geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb
> geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf
> geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064
> gradle/dependency-versions.properties 183dafc
>
>
> Diff: https://reviews.apache.org/r/60312/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>