[jira] [Commented] (KAFKA-5329) Replica list in the metadata cache on the broker may have different order from zookeeper

["Ismael Juma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026049#comment-16026049 ] 

Ismael Juma commented on KAFKA-5329:
------------------------------------

Are you sure that this is an issue [~becket_qin]? We rely on ControllerContext.partitionReplicaAssignment for the cases where the order matters and that does not use a Set. Also see https://github.com/apache/kafka/pull/900

> Replica list in the metadata cache on the broker may have different order from zookeeper
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5329
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5329
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.2.1
>            Reporter: Jiangjie Qin
>              Labels: newbie
>             Fix For: 0.11.0.1
>
>
> It looks that in {{PartitionStateInfo}} we are storing the replicas in a set instead of a Seq. This causes the replica order to be lost. In most case it is fine, but in the context of preferred leader election, the replica order determines which replica is the preferred leader of a partition. It would be useful to make the order always be consistent with the order in zookeeper. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)