You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/03/12 21:46:27 UTC

Review Request 19154: Restart does not seem to provide the Maintenance State info in the execution command

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19154/
-----------------------------------------------------------

Review request for Ambari and Sid Wagle.


Bugs: AMBARI-5057
    https://issues.apache.org/jira/browse/AMBARI-5057


Repository: ambari


Description
-------

* Restart commands don't follow the same mechanics as "normal" START/STOP commands.  They are custom commands that are builtin.  On a custom command, the Nagios server should receive all the passive info just like a start/stop would provide.
* Added some output to the agent script to confirm operation.
* Perf fix to reduce locks when generating the passive info.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java abd82ac 
  ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java 833e176 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server.py 32b6cd9 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c2192d0 

Diff: https://reviews.apache.org/r/19154/diff/


Testing
-------

Running org.apache.ambari.server.controller.AmbariManagementControllerTest
Tests run: 107, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 126.751 sec

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:12.485s
[INFO] Finished at: Wed Mar 12 16:31:23 EDT 2014
[INFO] Final Memory: 18M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole