[GitHub] [spark] xuanyuanking commented on a change in pull request #33827: [SPARK-36576][SS] Improve range split calculation for Kafka Source minPartitions option

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #33827:
URL: https://github.com/apache/spark/pull/33827#discussion_r696072488



##########
File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetRangeCalculator.scala
##########
@@ -56,11 +57,29 @@ private[kafka010] class KafkaOffsetRangeCalculator(val minPartitions: Option[Int
 
       // Splits offset ranges with relatively large amount of data to smaller ones.
       val totalSize = offsetRanges.map(_.size).sum
+
+      // First distinguish between any small (i.e. unsplit) ranges and large (i.e. split) ranges,

Review comment:
       Seems it's more clear to directly use unsplitRange and splitRange as the param name instead of small/large?
   (Not strong opinions, maybe just personal preference)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org