[GitHub] [carbondata] QiangCai commented on a change in pull request #3883: [CARBONDATA-3940] CommitTask fails due to Rename IOException during L…

[GitBox <gi...@apache.org>]

QiangCai commented on a change in pull request #3883:
URL: https://github.com/apache/carbondata/pull/3883#discussion_r466786922



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoHadoopFsRelationCommand.scala
##########
@@ -104,11 +104,13 @@ case class CarbonInsertIntoHadoopFsRelationCommand(
     val dynamicPartitionOverwrite = enableDynamicOverwrite && mode == SaveMode.Overwrite &&
                                     staticPartitions.size < partitionColumns.length
 
-    val committer = FileCommitProtocol.instantiate(
-      sparkSession.sessionState.conf.fileCommitProtocolClass,
-      jobId = java.util.UUID.randomUUID().toString,
-      outputPath = outputPath.toString,
-      dynamicPartitionOverwrite = dynamicPartitionOverwrite)
+    val committer = fileFormat match {

Review comment:
       better to check whether it is carbondata or carbonfile table in DDLStrategy.
   
   if the table is carbonfile table, it should not go to CarbonInsertIntoHadoopFsRelationCommand flow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org