You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Gary Yngve (JIRA)" <ji...@apache.org> on 2010/03/23 02:29:27 UTC

[jira] Created: (LUCENE-2342) DisjunctionSumScorer explain

DisjunctionSumScorer explain
----------------------------

                 Key: LUCENE-2342
                 URL: https://issues.apache.org/jira/browse/LUCENE-2342
             Project: Lucene - Java
          Issue Type: Bug
          Components: Search
            Reporter: Gary Yngve
            Priority: Minor


The bottom of the explain method in DisjunctionSumScorer says

    if (nrMatchers >= minimumNrMatchers) {

This is incorrect.. it should say

    if (nrMatches >= minimumNrMatchers) {

nrMatchers is the instance variable used for advancing, whereas nrMatches is explain's local variable.


Minor, because I don't think DSS's explain is ever called by anything (BooleanWeight has its own explain)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2342) DisjunctionSumScorer explain

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848560#action_12848560 ] 

Shai Erera commented on LUCENE-2342:
------------------------------------

Took me a while to spot the typo :). Can you reproduce a problem w/ a nice test case? So that we won't run into this issue in the future again.

> DisjunctionSumScorer explain
> ----------------------------
>
>                 Key: LUCENE-2342
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2342
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>            Reporter: Gary Yngve
>            Priority: Minor
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> The bottom of the explain method in DisjunctionSumScorer says
>     if (nrMatchers >= minimumNrMatchers) {
> This is incorrect.. it should say
>     if (nrMatches >= minimumNrMatchers) {
> nrMatchers is the instance variable used for advancing, whereas nrMatches is explain's local variable.
> Minor, because I don't think DSS's explain is ever called by anything (BooleanWeight has its own explain)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org