You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/25 17:47:12 UTC

[GitHub] [druid] jihoonson edited a comment on pull request #10013: Add NonnullPair

jihoonson edited a comment on pull request #10013:
URL: https://github.com/apache/druid/pull/10013#issuecomment-649726856


   @clintropolis thank you for the review.
   
   > Though now I wonder if `Pair` should be renamed `NullablePair` and this should be renamed `Pair` 🤔 😜
   
   Yeah, I agree it would be better. However, Intellij finds 1286 usages of `Pair` as of now, doing so will cause bunch of potential conflicts.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org