You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "TennyZhuang (via GitHub)" <gi...@apache.org> on 2026/05/01 14:46:24 UTC
[PR] feat(bindings/nodejs): add presignDelete [opendal]
TennyZhuang opened a new pull request, #7468:
URL: https://github.com/apache/opendal/pull/7468
# Which issue does this PR close?
No dedicated issue. This binding parity gap was found during a Slock OpenDAL binding regression.
Related but not closed: #7386 tracks S3 core enablement for presign delete. This PR only exposes the already-existing core `Operator::presign_delete` API through the Node.js binding.
# Rationale for this change
Rust core and Python already expose presigned DELETE support, and the Node.js binding already exposes the sibling `presignRead`, `presignWrite`, and `presignStat` methods.
Adding `presignDelete` closes that Node.js API parity gap without introducing option variants or changing existing methods.
# What changes are included in this PR?
- Add `Operator.presign_delete` to the Node.js NAPI binding, implemented through `self.async_op.presign_delete(...)`.
- Regenerate `bindings/nodejs/generated.d.ts` so TypeScript users get `presignDelete(path, expires)`.
- Keep the Node.js API flat, matching the existing `presignRead` / `presignWrite` / `presignStat` shape.
# Are there any user-facing changes?
Yes. Node.js users can now call:
```ts
const req = await op.presignDelete(path, expires)
```
This is additive and does not change existing behavior.
# Validation
- `pnpm build` in `bindings/nodejs` passed.
- Node smoke check confirmed `typeof op.presignDelete === "function"` and that unsupported-service errors propagate through the binding instead of panicking.
- `pnpm test -- --run` in `bindings/nodejs` could not run meaningful tests in this local environment because `bindings/nodejs/.env` is absent; Vitest reports `No test suite found` after skipping service tests for an empty scheme.
# AI Usage Statement
This PR was prepared during a Slock multi-agent regression using AI agents:
- OpenCode / DeepSeek v4-pro produced the initial patch.
- Codex / GPT-5.5 reviewed the diff and validation output before PR publication.
- Jianwei packaged and published the reviewed patch to GitHub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/nodejs): add presignDelete method and Capability getter [opendal]
Posted by "asukaminato0721 (via GitHub)" <gi...@apache.org>.
asukaminato0721 merged PR #7468:
URL: https://github.com/apache/opendal/pull/7468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org