You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/06 11:50:08 UTC
[GitHub] [flink] echauchot opened a new pull request, #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
echauchot opened a new pull request, #20184:
URL: https://github.com/apache/flink/pull/20184
## Contribution Checklist
## What is the purpose of the change
Raise driver timeouts per session request and raise it higher than cluster side timetouts
## Brief change log
Change in the CassandraITCase
## Verifying this change
This change is already covered by existing tests, such as *CassandraITCase*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
R: @MartijnVisser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
echauchot commented on PR #20184:
URL: https://github.com/apache/flink/pull/20184#issuecomment-1178759024
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
echauchot commented on PR #20184:
URL: https://github.com/apache/flink/pull/20184#issuecomment-1178737170
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
echauchot commented on PR #20184:
URL: https://github.com/apache/flink/pull/20184#issuecomment-1178731452
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on a diff in pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
echauchot commented on code in PR #20184:
URL: https://github.com/apache/flink/pull/20184#discussion_r916606194
##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java:
##########
@@ -458,7 +464,10 @@ protected Tuple3<String, Integer, Integer> generateValue(int counter, int checkp
protected void verifyResultsIdealCircumstances(
CassandraTupleWriteAheadSink<Tuple3<String, Integer, Integer>> sink) {
- ResultSet result = session.execute(injectTableName(SELECT_DATA_QUERY));
+ ResultSet result =
+ session.execute(
+ new SimpleStatement(injectTableName(SELECT_DATA_QUERY))
+ .setReadTimeoutMillis(READ_TIMEOUT_MILLIS));
Review Comment:
Yes but as I wrote in the ticket:
> "the driver timeouts were set on the clusterBuilder because previous timeout errors were only on test cases. Here, the request timeouts are on session.execute that do not use the ClusterBuilder. Thus, they use the default 12s timeout. I'll raise to 36s per session request."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on a diff in pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
echauchot commented on code in PR #20184:
URL: https://github.com/apache/flink/pull/20184#discussion_r919831064
##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java:
##########
@@ -458,7 +464,10 @@ protected Tuple3<String, Integer, Integer> generateValue(int counter, int checkp
protected void verifyResultsIdealCircumstances(
CassandraTupleWriteAheadSink<Tuple3<String, Integer, Integer>> sink) {
- ResultSet result = session.execute(injectTableName(SELECT_DATA_QUERY));
+ ResultSet result =
+ session.execute(
+ new SimpleStatement(injectTableName(SELECT_DATA_QUERY))
+ .setReadTimeoutMillis(READ_TIMEOUT_MILLIS));
Review Comment:
@zentol there has been several of these timeout issues that make the build flaky. @MartijnVisser pinged me to quickly solve this issue. Tell me if you need anything more on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on a diff in pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
echauchot commented on code in PR #20184:
URL: https://github.com/apache/flink/pull/20184#discussion_r916606194
##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java:
##########
@@ -458,7 +464,10 @@ protected Tuple3<String, Integer, Integer> generateValue(int counter, int checkp
protected void verifyResultsIdealCircumstances(
CassandraTupleWriteAheadSink<Tuple3<String, Integer, Integer>> sink) {
- ResultSet result = session.execute(injectTableName(SELECT_DATA_QUERY));
+ ResultSet result =
+ session.execute(
+ new SimpleStatement(injectTableName(SELECT_DATA_QUERY))
+ .setReadTimeoutMillis(READ_TIMEOUT_MILLIS));
Review Comment:
Yes but as I wrote in the ticket:
> "the driver timeouts were set on the clusterBuilder because previous timeout errors were only on test cases. Here, the request timeouts are on session.execute that do not use the ClusterBuilder. Thus, they use the default 12s timeout. I'll raise to 36s per session request."
the `ClusterBuilder` is only used for Sinks, InputFormats, OutputFormats, etc... but not for `session.execute` requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #20184:
URL: https://github.com/apache/flink/pull/20184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20184:
URL: https://github.com/apache/flink/pull/20184#issuecomment-1176131957
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4244419154ee6bb70981a25dee11b84969b79a5f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4244419154ee6bb70981a25dee11b84969b79a5f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4244419154ee6bb70981a25dee11b84969b79a5f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20184: [FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20184:
URL: https://github.com/apache/flink/pull/20184#discussion_r914779600
##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java:
##########
@@ -458,7 +464,10 @@ protected Tuple3<String, Integer, Integer> generateValue(int counter, int checkp
protected void verifyResultsIdealCircumstances(
CassandraTupleWriteAheadSink<Tuple3<String, Integer, Integer>> sink) {
- ResultSet result = session.execute(injectTableName(SELECT_DATA_QUERY));
+ ResultSet result =
+ session.execute(
+ new SimpleStatement(injectTableName(SELECT_DATA_QUERY))
+ .setReadTimeoutMillis(READ_TIMEOUT_MILLIS));
Review Comment:
Isn't this already set in the cluster builder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org