You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Ja...@rzf.fin-nrw.de on 2005/05/03 08:28:38 UTC

AW: AW: cvs commit: ant/src/main/org/apache/tools/ant DemuxOutput Stre am.java

> > Mmh checkstyle-config [1] sais 
> >     <module name="LineLength">
> >       <property name="max" value="100"/>
> >       <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
> >     </module>
> > sounds like java-length-max is 100, javadoc-length-max isnt set.
> > 
> 
> I think I set that originally. I probably chose that as a more 
> achievable goal to start with.


I think the Sun guidelines use 80.
But should we change? How many sources have lines>80?

Jan

Re: AW: AW: cvs commit: ant/src/main/org/apache/tools/ant DemuxOutput Stre am.java

Posted by Peter Reilly <pe...@apache.org>.
Jan.Materne@rzf.fin-nrw.de wrote:

>>>Mmh checkstyle-config [1] sais 
>>>    <module name="LineLength">
>>>      <property name="max" value="100"/>
>>>      <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
>>>    </module>
>>>sounds like java-length-max is 100, javadoc-length-max isnt set.
>>>
>>>      
>>>
>>I think I set that originally. I probably chose that as a more 
>>achievable goal to start with.
>>    
>>
>
>
>I think the Sun guidelines use 80.
>But should we change? How many sources have lines>80?
>  
>
We should try to make the code complient with the current rules
before making the rules more restrictive. 100 characters is fine, it
catches the silly 1000 character lines.

Peter

>Jan
>
>  
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org