You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/30 22:35:55 UTC
[GitHub] [pinot] codecov-commenter commented on pull request #10817: Make OrderByComparatorFactory consume OrderByExpressionContext::isNullsLast.
codecov-commenter commented on PR #10817:
URL: https://github.com/apache/pinot/pull/10817#issuecomment-1569218864
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10817](https://app.codecov.io/gh/apache/pinot/pull/10817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (49f2f19) into [master](https://app.codecov.io/gh/apache/pinot/commit/c48f4b3771f62e6a6fdd32376baf6b4c8701b0d8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c48f4b3) will **decrease** coverage by `32.33%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #10817 +/- ##
=============================================
- Coverage 64.33% 32.00% -32.33%
+ Complexity 6505 462 -6043
=============================================
Files 2110 2164 +54
Lines 113914 116408 +2494
Branches 17310 17609 +299
=============================================
- Hits 73284 37260 -36024
- Misses 35361 75851 +40490
+ Partials 5269 3297 -1972
```
| Flag | Coverage Δ | |
|---|---|---|
| integration2 | `23.51% <50.00%> (?)` | |
| unittests1 | `?` | |
| unittests2 | `13.64% <0.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...not/core/query/utils/OrderByComparatorFactory.java](https://app.codecov.io/gh/apache/pinot/pull/10817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS91dGlscy9PcmRlckJ5Q29tcGFyYXRvckZhY3RvcnkuamF2YQ==) | `45.94% <50.00%> (-45.49%)` | :arrow_down: |
... and [1542 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10817/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org