[GitHub] [geode] PurelyApplied opened pull request #2977: GEODE-6169: Apply dependencyManagement to all modules.

["PurelyApplied (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2977 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2977: GEODE-6169: Apply dependencyManagement to all modules.

["PurelyApplied (GitHub)" <gi...@apache.org>]

Also, the dependency block was script-generated; many of the dependency constraints could be rewritten as `dependencySet` to avoid accidental drift between, e.g., various `log4j` modules.

[ Full content available at: https://github.com/apache/geode/pull/2977 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #2977: GEODE-6169: Apply dependencyManagement to all modules.

["PurelyApplied (GitHub)" <gi...@apache.org>]

[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/2977 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2977: GEODE-6169: Apply dependencyManagement to all modules.

["PurelyApplied (GitHub)" <gi...@apache.org>]

As a point of inquiry in this PR: I am not familiar enough with POMs to know if the presence of the very-verbose `dependencyManagement` block in each expected POM, even though the POM itself may not need the libraries specified, is bad practice or potentially breaking to a consumer.  I would appreciate comment on that front.

[ Full content available at: https://github.com/apache/geode/pull/2977 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org