You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/05/07 15:55:33 UTC
[kudu-CR] [java] Disable javadoc generation in Java 10+
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10326
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
[java] Disable javadoc generation in Java 10+
Javadoc is currently broken in Java 10+. Given we likely will
never release from Java 10, this change disables it until fixed
at a later date.
Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
---
M java/gradle/docs.gradle
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/10326/1
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Disable javadoc generation in Java 10+
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10326 )
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
Patch Set 1:
(1 comment)
Do we need an equivalent change for Maven?
http://gerrit.cloudera.org:8080/#/c/10326/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10326/1//COMMIT_MSG@9
PS1, Line 9: Given we likely will
: never release from Java 10
Did you mean to say that we're not going to release from it in the near future? I mean, eventually we will release using Java 10, 11, 12, or whatever, right? 'Never' seems like a strong word.
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 07 May 2018 19:54:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Disable javadoc generation in Java 10+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10326 )
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
Patch Set 1:
(1 comment)
Given the plan is to phase out the maven build, I was planning to leave this out for Maven. I find the java version profiles in maven to be a bit of a pain.
http://gerrit.cloudera.org:8080/#/c/10326/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10326/1//COMMIT_MSG@9
PS1, Line 9: Given we likely will
: never release from Java 10
> Did you mean to say that we're not going to release from it in the near fut
Given Java 9 and 10 are not LTS releases I suspect we will focus mainly on Java 11.
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 07 May 2018 19:57:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Disable javadoc generation in Java 10+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10326
to look at the new patch set (#2).
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
[java] Disable javadoc generation in Java 10+
Javadoc is currently broken in Java 10+. This patch does
not fix javadocs but instead disables them when compiling
with Java 10 or higher.
We should revisit this in the future (perhaps when Java 11
is out) and hopefully by then Java, Gradle, or Yetus will
have made this easy.
Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
---
M java/gradle/docs.gradle
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/10326/2
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Disable javadoc generation in Java 10+
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10326 )
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10326/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10326/1//COMMIT_MSG@9
PS1, Line 9: Given we likely will
: never release from Java 10
> Given Java 9 and 10 are not LTS releases I suspect we will focus mainly on
Okay, maybe I just don't understand the connection between the first half of the sentence and the second. I agree that we're very unlikely to release from Java 10 specifically, but we'll definitely release from some 10+ version of Java.
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 07 May 2018 20:02:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Disable javadoc generation in Java 10+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10326 )
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
[java] Disable javadoc generation in Java 10+
Javadoc is currently broken in Java 10+. This patch does
not fix javadocs but instead disables them when compiling
with Java 10 or higher.
We should revisit this in the future (perhaps when Java 11
is out) and hopefully by then Java, Gradle, or Yetus will
have made this easy.
Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Reviewed-on: http://gerrit.cloudera.org:8080/10326
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/gradle/docs.gradle
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Disable javadoc generation in Java 10+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10326 )
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 07 May 2018 21:00:02 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Disable javadoc generation in Java 10+
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10326 )
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 07 May 2018 20:56:35 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Disable javadoc generation in Java 10+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10326 )
Change subject: [java] Disable javadoc generation in Java 10+
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10326/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10326/1//COMMIT_MSG@9
PS1, Line 9: Given we likely will
: never release from Java 10
> Okay, maybe I just don't understand the connection between the first half o
Yeah, I could update the message for this. I just meant to say it's not necessary to solve now. Perhaps by the time Java 11 roles around, gradle, yetus, or java will make this easier.
--
To view, visit http://gerrit.cloudera.org:8080/10326
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a5803dec97713ff564e7169da3825dbf3231806
Gerrit-Change-Number: 10326
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 07 May 2018 20:05:04 +0000
Gerrit-HasComments: Yes