You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ksumit (via GitHub)" <gi...@apache.org> on 2023/04/04 19:12:08 UTC
[GitHub] [spark] ksumit opened a new pull request, #40667: Improve IDE build experience against jdk11
ksumit opened a new pull request, #40667:
URL: https://github.com/apache/spark/pull/40667
### What changes were proposed in this pull request?
Building the project against jdk11 on IDE shows errors because `Platform.java` depends on `sun.misc` which is in `jdk.unsupported` module in jdk11. The problem goes away when we pass `java.version` as `11` to maven as system D parameters.
This PR set `java.version` to `11` by detecting jdk version automatically and improves build experience.
### Why are the changes needed?
It makes build experience on IDE against jdk11 smoother.
### Does this PR introduce _any_ user-facing change?
Users won't have to specify java.version in maven parameters any more since the profile gets activated automagically based on the jdk version.
### How was this patch tested?
This patch was tested by building locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #40667: Improve IDE build experience against jdk11
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40667: Improve IDE build experience against jdk11
URL: https://github.com/apache/spark/pull/40667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #40667: Improve IDE build experience against jdk11
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40667:
URL: https://github.com/apache/spark/pull/40667#issuecomment-1635085283
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org