You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/21 07:37:22 UTC
[GitHub] [incubator-inlong] GanfengTan commented on a diff in pull request #4290: [INLONG-4282][Sort] Optimize the sort package structure
GanfengTan commented on code in PR #4290:
URL: https://github.com/apache/incubator-inlong/pull/4290#discussion_r878658515
##########
inlong-sort/sort-connectors/sort-kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaDynamicTableFactory.java:
##########
@@ -89,8 +89,8 @@
import static org.apache.flink.table.factories.FactoryUtil.SINK_PARALLELISM;
/**
- * Copy from org.apache.flink:flink-connector-kafka_2.11:1.13.5
- *
+ * Copy from org.apache.flink:flink-connector-kafka_2.11:1.13.5
+ * <p>
Review Comment:
Please revise it.
##########
inlong-sort/sort-connectors/sort-jdbc/src/main/java/org/apache/inlong/sort/jdbc/table/JdbcDynamicTableFactory.java:
##########
@@ -48,7 +48,7 @@
/**
* Copy from org.apache.flink:flink-connector-jdbc_2.11:1.13.5
- *
+ * <p>
Review Comment:
<img width="306" alt="image" src="https://user-images.githubusercontent.com/17596132/169640732-b4c441b5-59f1-4c0d-926d-d5c5a480fa55.png">
Please revise it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org