You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Nebojsa Sabovic (Created) (JIRA)" <ji...@apache.org> on 2011/10/06 23:11:29 UTC

[jira] [Created] (AVRO-913) CMake/C++ build should work for out-of-tree builds

CMake/C++ build should work for out-of-tree builds
--------------------------------------------------

                 Key: AVRO-913
                 URL: https://issues.apache.org/jira/browse/AVRO-913
             Project: Avro
          Issue Type: Bug
          Components: c++
    Affects Versions: 1.5.4
            Reporter: Nebojsa Sabovic


C++ CMake file sets the build directory to the source root and then forces build output into build/ directory under root. This breaks out-of-tree builds.

CMake already has a facility for choosing build directory. We should use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (AVRO-913) CMake/C++ build should work for out-of-tree builds

Posted by "Thiruvalluvan M. G. (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. reassigned AVRO-913:
----------------------------------------

    Assignee: Nebojsa Sabovic
    
> CMake/C++ build should work for out-of-tree builds
> --------------------------------------------------
>
>                 Key: AVRO-913
>                 URL: https://issues.apache.org/jira/browse/AVRO-913
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.5.4
>            Reporter: Nebojsa Sabovic
>            Assignee: Nebojsa Sabovic
>              Labels: cmake
>         Attachments: AVRO-913.patch
>
>
> C++ CMake file sets the build directory to the source root and then forces build output into build/ directory under root. This breaks out-of-tree builds.
> CMake already has a facility for choosing build directory. We should use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-913) CMake/C++ build should work for out-of-tree builds

Posted by "Nebojsa Sabovic (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nebojsa Sabovic updated AVRO-913:
---------------------------------

    Attachment: AVRO-913.patch

Use cmake_bin_dir/cmake_source_dir for supporting out-of-tree builds
                
> CMake/C++ build should work for out-of-tree builds
> --------------------------------------------------
>
>                 Key: AVRO-913
>                 URL: https://issues.apache.org/jira/browse/AVRO-913
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.5.4
>            Reporter: Nebojsa Sabovic
>              Labels: cmake
>         Attachments: AVRO-913.patch
>
>
> C++ CMake file sets the build directory to the source root and then forces build output into build/ directory under root. This breaks out-of-tree builds.
> CMake already has a facility for choosing build directory. We should use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (AVRO-913) CMake/C++ build should work for out-of-tree builds

Posted by "Thiruvalluvan M. G. (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124031#comment-13124031 ] 

Thiruvalluvan M. G. commented on AVRO-913:
------------------------------------------

If there are no objections, I'll commit this tomorrow.
                
> CMake/C++ build should work for out-of-tree builds
> --------------------------------------------------
>
>                 Key: AVRO-913
>                 URL: https://issues.apache.org/jira/browse/AVRO-913
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.5.4
>            Reporter: Nebojsa Sabovic
>            Assignee: Nebojsa Sabovic
>              Labels: cmake
>         Attachments: AVRO-913.patch
>
>
> C++ CMake file sets the build directory to the source root and then forces build output into build/ directory under root. This breaks out-of-tree builds.
> CMake already has a facility for choosing build directory. We should use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (AVRO-913) CMake/C++ build should work for out-of-tree builds

Posted by "Thiruvalluvan M. G. (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125988#comment-13125988 ] 

Thiruvalluvan M. G. commented on AVRO-913:
------------------------------------------

Thank you Nebojsa.
                
> CMake/C++ build should work for out-of-tree builds
> --------------------------------------------------
>
>                 Key: AVRO-913
>                 URL: https://issues.apache.org/jira/browse/AVRO-913
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.5.4
>            Reporter: Nebojsa Sabovic
>            Assignee: Nebojsa Sabovic
>              Labels: cmake
>             Fix For: 1.6.0
>
>         Attachments: AVRO-913.patch
>
>
> C++ CMake file sets the build directory to the source root and then forces build output into build/ directory under root. This breaks out-of-tree builds.
> CMake already has a facility for choosing build directory. We should use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-913) CMake/C++ build should work for out-of-tree builds

Posted by "Thiruvalluvan M. G. (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-913:
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6.0
           Status: Resolved  (was: Patch Available)

Committed revision 1182482.
                
> CMake/C++ build should work for out-of-tree builds
> --------------------------------------------------
>
>                 Key: AVRO-913
>                 URL: https://issues.apache.org/jira/browse/AVRO-913
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.5.4
>            Reporter: Nebojsa Sabovic
>            Assignee: Nebojsa Sabovic
>              Labels: cmake
>             Fix For: 1.6.0
>
>         Attachments: AVRO-913.patch
>
>
> C++ CMake file sets the build directory to the source root and then forces build output into build/ directory under root. This breaks out-of-tree builds.
> CMake already has a facility for choosing build directory. We should use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-913) CMake/C++ build should work for out-of-tree builds

Posted by "Nebojsa Sabovic (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nebojsa Sabovic updated AVRO-913:
---------------------------------

    Status: Patch Available  (was: Open)
    
> CMake/C++ build should work for out-of-tree builds
> --------------------------------------------------
>
>                 Key: AVRO-913
>                 URL: https://issues.apache.org/jira/browse/AVRO-913
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.5.4
>            Reporter: Nebojsa Sabovic
>              Labels: cmake
>         Attachments: AVRO-913.patch
>
>
> C++ CMake file sets the build directory to the source root and then forces build output into build/ directory under root. This breaks out-of-tree builds.
> CMake already has a facility for choosing build directory. We should use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira