You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/13 17:17:59 UTC
[GitHub] [flink] zhuxiaoshang opened a new pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
zhuxiaoshang opened a new pull request #13620:
URL: https://github.com/apache/flink/pull/13620
## What is the purpose of the change
*fix the typo in the doc of FileSystem*
## Brief change log
- change the first `FSDataOutputStream` to `FSDataInputStream`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-707891734
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 16f95599c033e72ce486b06dd3d527abd656b1a9 (Tue Oct 13 17:20:38 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #13620:
URL: https://github.com/apache/flink/pull/13620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546",
"triggerID" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"triggerType" : "PUSH"
}, {
"hash" : "4290129d21b0600e5d17b1c9db54c9416a861b2c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8489",
"triggerID" : "4290129d21b0600e5d17b1c9db54c9416a861b2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4290129d21b0600e5d17b1c9db54c9416a861b2c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-717801129
@JingsongLi plz have a review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546",
"triggerID" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16f95599c033e72ce486b06dd3d527abd656b1a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546",
"triggerID" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"triggerType" : "PUSH"
}, {
"hash" : "4290129d21b0600e5d17b1c9db54c9416a861b2c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4290129d21b0600e5d17b1c9db54c9416a861b2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16f95599c033e72ce486b06dd3d527abd656b1a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546)
* 4290129d21b0600e5d17b1c9db54c9416a861b2c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16f95599c033e72ce486b06dd3d527abd656b1a9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-712093131
Thanks for catching this.
+1 to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546",
"triggerID" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"triggerType" : "PUSH"
}, {
"hash" : "4290129d21b0600e5d17b1c9db54c9416a861b2c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8489",
"triggerID" : "4290129d21b0600e5d17b1c9db54c9416a861b2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16f95599c033e72ce486b06dd3d527abd656b1a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546)
* 4290129d21b0600e5d17b1c9db54c9416a861b2c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546",
"triggerID" : "16f95599c033e72ce486b06dd3d527abd656b1a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16f95599c033e72ce486b06dd3d527abd656b1a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuxiaoshang commented on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178
Posted by GitBox <gi...@apache.org>.
zhuxiaoshang commented on pull request #13620:
URL: https://github.com/apache/flink/pull/13620#issuecomment-708221561
The reason about Azure failure can refer to FLINK-19619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org