[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #92: HDDS-2345. Add a UT for newly added clone() in OmBucketInfo

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #92: HDDS-2345. Add a UT for newly added clone() in OmBucketInfo
URL: https://github.com/apache/hadoop-ozone/pull/92#discussion_r339301819
 
 

 ##########
 File path: hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/helpers/TestOmBucketInfo.java
 ##########
 @@ -41,6 +42,21 @@ public void protobufConversion() {
         OmBucketInfo.getFromProtobuf(bucket.getProtobuf());
 
     Assert.assertEquals(bucket, afterSerialization);
+  }
+
+  @Test
+  public void testClone() {
+    OmBucketInfo omBucketInfo = OmBucketInfo.newBuilder()
+        .setBucketName("bucket")
+        .setVolumeName("vol1")
+        .setCreationTime(Time.now())
+        .setIsVersionEnabled(false)
+        .setStorageType(StorageType.ARCHIVE)
+        .build();
 
 Review comment:
   Can you add some test with setAcls and check the behavior for reference check TestOmVolumeArgs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org