[GitHub] [pulsar] lhotari commented on a diff in pull request #15942: [feature][broker] Support HTTP endpoint consume messages

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #15942:
URL: https://github.com/apache/pulsar/pull/15942#discussion_r889871077


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/Topics.java:
##########
@@ -157,4 +164,140 @@ public void produceOnNonPersistentTopicPartition(@Suspended final AsyncResponse
         }
     }
 
+    @POST
+    @Path("/persistent/{tenant}/{namespace}/{topic}/subscription/{subscription}")

Review Comment:
   Shouldn't the API path contain end with "/consumers" if this API method creates a consumer?
   ```suggestion
       @Path("/persistent/{tenant}/{namespace}/{topic}/subscription/{subscription}/consumers")
   ```



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/Topics.java:
##########
@@ -157,4 +164,140 @@ public void produceOnNonPersistentTopicPartition(@Suspended final AsyncResponse
         }
     }
 
+    @POST
+    @Path("/persistent/{tenant}/{namespace}/{topic}/subscription/{subscription}")

Review Comment:
   Shouldn't the API path end with "/consumers" if this API method creates a consumer?
   ```suggestion
       @Path("/persistent/{tenant}/{namespace}/{topic}/subscription/{subscription}/consumers")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org